Enable PSNR by default and add MB config for rtc_video_psnr=false to "Linux (more configs)" bot
Enabling PSN
Bug: webrtc:388070060
Change-Id: I9332651dd8d3515c75c812939bd5916640456063
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/404541
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#45396}
diff --git a/tools_webrtc/mb/mb_config.pyl b/tools_webrtc/mb/mb_config.pyl
index 0373d12..95f8d10 100644
--- a/tools_webrtc/mb/mb_config.pyl
+++ b/tools_webrtc/mb/mb_config.pyl
@@ -62,6 +62,7 @@
'openssl': 'openssl_x64',
'libstdcpp': 'libstdcpp_x64',
'no_lld': 'no_lld_x64',
+ 'no_psnr': 'no_psnr_x64',
},
'Linux Asan': 'asan_lsan_clang_release_bot_x64',
'Linux MSan': 'msan_clang_release_bot_x64',
@@ -192,6 +193,7 @@
'openssl': 'openssl_x64',
'libstdcpp': 'libstdcpp_x64',
'no_lld': 'no_lld_x64',
+ 'no_psnr': 'no_psnr_x64',
},
'linux_msan': 'msan_clang_release_bot_x64',
'linux_rel': 'release_bot_x64',
@@ -410,6 +412,7 @@
['msan', 'clang', 'openh264', 'pure_release_bot', 'x64', 'h265'],
'no_h264_debug_bot_x86': ['debug_bot', 'x86'],
'no_lld_x64': ['debug_bot', 'x64', 'no_lld'],
+ 'no_psnr_x64': ['debug_bot', 'x64', 'no_psnr'],
'openssl_x64': ['debug_bot', 'x64', 'no_build_ssl'],
'perfetto_android_arm': [
'android',
@@ -590,6 +593,9 @@
'no_protobuf': {
'gn_args': 'rtc_enable_protobuf=false',
},
+ 'no_psnr': {
+ 'gn_args': 'rtc_video_psnr=false',
+ },
'no_sctp': {
'gn_args': 'rtc_enable_sctp=false',
},
diff --git a/webrtc.gni b/webrtc.gni
index fc85600..7ba8e32 100644
--- a/webrtc.gni
+++ b/webrtc.gni
@@ -321,7 +321,7 @@
rtc_rusty_base64 = false
# Enables PSNR calculation for video getStats.
- rtc_video_psnr = build_with_chromium
+ rtc_video_psnr = true
}
declare_args() {