commit | b0bb77fd615c5ce413b16f6157b2ffc25898631f | [log] [tgz] |
---|---|---|
author | guoweis <guoweis@webrtc.org> | Mon Oct 26 22:10:01 2015 |
committer | Commit bot <commit-bot@chromium.org> | Mon Oct 26 22:10:06 2015 |
tree | ae7e32596506425c0d3dde7e7f0d1636fa91c56f | |
parent | 8f46c63f6f764254892f4111b54aa1cc8f32eeeb [diff] |
Reland of Add experiment on weak ping delay during call set up time (patchset #1 id:1 of https://codereview.webrtc.org/1416773003/ ) Reason for revert: https://codereview.chromium.org/1419253002 is landed to address this linker issue. Keep my fingers crossed. Original issue's description: > Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ ) > > Reason for revert: > This CL breaks Chromium, undefined reference link error to webrtc::field_trial::FindFullName. Adding the dependency system_wrappers to the rtc_p2p target is not enough to fix this. > > Looking at field_trial.h (in system_wrappers/interface/, not to be confused with the one in test/) the documentation says "WebRTC clients MUST provide an implementation of: ...FindFullName... Or link with a default one provided in: ...system_wrappers.gyp:field_trial_default). > > So maybe just depend on field_trial_default? Not sure what should be done in case there are implications to adding this dependency, I'm reverting this. Sorry :) > > Original issue's description: > > Add experiment on weak ping delay during call set up time > > > > BUG= > > R=pthatcher@webrtc.org > > > > Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279 > > Cr-Commit-Position: refs/heads/master@{#10343} > > TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > TBR=pthatcher@webrtc.org,juberti@webrtc.org,hbos@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.webrtc.org/1413603005 Cr-Commit-Position: refs/heads/master@{#10418}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.