Check that data_ is non-null before memcpy in EnsureCapacityWithHeadroom

Since we've passed IsConsistent(), if data_ is null, size_ must be
zero, so we might attempt to copy zero bytes from a nullptr.  This does
not seem to cause problems in practice, but is still undefined
behaviour. This was caught on an UBsan test run in Firefox.

Bug: webrtc:11613
Change-Id: Iad795bf19ed69b56e066958a54a7e3a434b996cf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176280
Commit-Queue: Dan Minor <dminor@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31386}
1 file changed
tree: 5e9098d4942e60f201fb4df45755aca7f02ada15
  1. .clang-format
  2. .git-blame-ignore-revs
  3. .gitignore
  4. .gn
  5. .vpython
  6. AUTHORS
  7. BUILD.gn
  8. CODE_OF_CONDUCT.md
  9. DEPS
  10. ENG_REVIEW_OWNERS
  11. LICENSE
  12. OWNERS
  13. PATENTS
  14. PRESUBMIT.py
  15. README.chromium
  16. README.md
  17. WATCHLISTS
  18. abseil-in-webrtc.md
  19. api/
  20. audio/
  21. build_overrides/
  22. call/
  23. codereview.settings
  24. common_audio/
  25. common_types.h
  26. common_video/
  27. data/
  28. docs/
  29. examples/
  30. license_template.txt
  31. logging/
  32. media/
  33. modules/
  34. native-api.md
  35. p2p/
  36. pc/
  37. presubmit_test.py
  38. presubmit_test_mocks.py
  39. pylintrc
  40. resources/
  41. rtc_base/
  42. rtc_tools/
  43. sdk/
  44. stats/
  45. style-guide.md
  46. style-guide/
  47. system_wrappers/
  48. test/
  49. tools_webrtc/
  50. video/
  51. webrtc.gni
  52. webrtc_lib_link_test.cc
  53. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info