commit b39db841b6cd83f221f05ee5f7b91e799a4346b1
author hta <hta@webrtc.org> Thu Dec 08 09:50:48 2016
committer Commit bot <commit-bot@chromium.org> Thu Dec 08 09:50:52 2016
tree 18978b34bbdc47010ef8d8474b3df47c0a239809
parent 06a69849350c11c810a57d4468683032ecc08df8

Refactoring: Declare cricket::Codec constructors protected.

This makes it obvious that cricket::Codec should not be
instantiated; only subclasses should be instantiated.

BUG=none

Review-Url: https://codereview.webrtc.org/2546363002
Cr-Commit-Position: refs/heads/master@{#15468}

webrtc/media/base/codec_unittest.cc

diff --git a/webrtc/media/base/codec_unittest.cc b/webrtc/media/base/codec_unittest.cc
index 8dd2e44..77c1fd0 100644
--- a/webrtc/media/base/codec_unittest.cc
+++ b/webrtc/media/base/codec_unittest.cc
@@ -20,11 +20,19 @@
 using cricket::kCodecParamMaxBitrate;
 using cricket::kCodecParamMinBitrate;
 
+class TestCodec : public Codec {
+ public:
+  TestCodec(int id, const std::string name, int clockrate)
+      : Codec(id, name, clockrate) {}
+  TestCodec() : Codec() {}
+  TestCodec(const TestCodec& c) : Codec(c) {}
+};
+
 TEST(CodecTest, TestCodecOperators) {
-  Codec c0(96, "D", 1000);
+  TestCodec c0(96, "D", 1000);
   c0.SetParam("a", 1);
 
-  Codec c1 = c0;
+  TestCodec c1 = c0;
   EXPECT_TRUE(c1 == c0);
 
   int param_value0;
@@ -48,8 +56,8 @@
   c1.SetParam("a", 2);
   EXPECT_TRUE(c0 != c1);
 
-  Codec c5;
-  Codec c6(0, "", 0);
+  TestCodec c5;
+  TestCodec c6(0, "", 0);
   EXPECT_TRUE(c5 == c6);
 }
 
@@ -220,11 +228,11 @@
   const FeedbackParam b2("b", "2");
   const FeedbackParam b3("b", "3");
   const FeedbackParam c3("c", "3");
-  Codec c1;
+  TestCodec c1;
   c1.AddFeedbackParam(a1); // Only match with c2.
   c1.AddFeedbackParam(b2); // Same param different values.
   c1.AddFeedbackParam(c3); // Not in c2.
-  Codec c2;
+  TestCodec c2;
   c2.AddFeedbackParam(a1);
   c2.AddFeedbackParam(b3);