commit | b7318f1293453d8d319e27473c5bfb72292ebfd2 | [log] [tgz] |
---|---|---|
author | tommi <tommi@webrtc.org> | Thu May 26 15:17:23 2016 |
committer | Commit bot <commit-bot@chromium.org> | Thu May 26 15:17:29 2016 |
tree | 1ee766e8aac6b60939227269fd1c8d8523028348 | |
parent | d591e3fcf33a4c692cd49294b22dd21bb117cd19 [diff] |
Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2006313009/ ) Reason for revert: Relanding. The errors look like legit disk space problems so I'm going to watch the bots this time. Original issue's description: > Revert of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2009253004/ ) > > Reason for revert: > Fails unexpectedly on multiple commit bots: > https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug%20%28Clang%29/builds/1748 > https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%29/builds/1683 > > I filed https://bugs.chromium.org/p/chromium/issues/detail?id=614967 to track the problem. I'll reland if it doesn't solve the problem. > > Original issue's description: > > Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ ) > > > > Original issue's description: > > > Adding a some checks and switching out a few assert for RTC_[D]CHECK. > > > These changes are around use of AudioFrame.data_ to help us catch issues earlier since assert() is left out in release builds, including builds with DCHECK enabled. I've also added a few full-on CHECKs to avoid reading past buffer boundaries or continuing on in a failed state. > > > > > > BUG=chromium:613482 > > > NOTRY=true > > > (using notry due to offline android_arm64_rel bot) > > > > > > Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b > > > Cr-Commit-Position: refs/heads/master@{#12870} > > > > TBR=henrik.lundin@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=chromium:613482 > > > > Committed: https://crrev.com/ba189cc4f4f6fe311a815646059e8011ffa53894 > > Cr-Commit-Position: refs/heads/master@{#12907} > > TBR=henrik.lundin@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:613482 > > Committed: https://crrev.com/6895d8ca788df29f4d3a4b97fe891f0fb3a6dbec > Cr-Commit-Position: refs/heads/master@{#12909} TBR=henrik.lundin@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:613482 Review-Url: https://codereview.webrtc.org/2014183003 Cr-Commit-Position: refs/heads/master@{#12920}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.