Google Git
Sign in
webrtc / src / b7dc45f8e8119d367b7513045db7cce68861709f
commitb7dc45f8e8119d367b7513045db7cce68861709f[log] [tgz]
authorMirko Bonadei <mbonadei@webrtc.org>Tue Jan 21 07:42:41 2020
committerCommit Bot <commit-bot@chromium.org>Tue Jan 21 11:06:40 2020
treede6e2c27176594b436ad0412b1f358c1987d55da
parente77f94c54cd22b6ee09b43775475b5437b9d1697 [diff]
Update check_package_boundaries.

Before reformatting GN files (see [1] for why this is needed), the
presubmit check to ensure targets are not violating package boundaries
needs to be fixed because its regular expressions don't always work with
the new format.

This CL removes the parsing of line numbers to relax the regular
expressions without losing any functionality.

Error before this CL:
***************
<PATH>/webrtc/src/BUILD.gn:674 in target 'android_junit_tests':
  Source file 'examples/androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java'
  crosses boundary of package 'examples'.

<PATH>/webrtc/src/BUILD.gn:675 in target 'android_junit_tests':
  Source file 'examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java'
  crosses boundary of package 'examples'.

<PATH>/webrtc/src/BUILD.gn:676 in target 'android_junit_tests':
  Source file 'examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java'
  crosses boundary of package 'examples'.

<PATH>/webrtc/src/BUILD.gn:677 in target 'android_junit_tests':
  Source file 'sdk/android/tests/src/org/webrtc/AndroidVideoDecoderTest.java'
  crosses boundary of package 'sdk'.

<PATH>/webrtc/src/BUILD.gn:678 in target 'android_junit_tests':
  Source file 'sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java'
  crosses boundary of package 'sdk'.
***************


Error after this CL:
***************
<PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests':
  Source file 'examples/androidjunit/src/org/appspot/apprtc/BluetoothManagerTest.java'
  crosses boundary of package 'examples'.

<PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests':
  Source file 'examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java'
  crosses boundary of package 'examples'.

<PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests':
  Source file 'examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java'
  crosses boundary of package 'examples'.

<PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests':
  Source file 'sdk/android/tests/src/org/webrtc/AndroidVideoDecoderTest.java'
  crosses boundary of package 'sdk'.

<PATH>/webrtc/src/BUILD.gn in target 'android_junit_tests':
  Source file 'sdk/android/tests/src/org/webrtc/CameraEnumerationTest.java'
  crosses boundary of package 'sdk'.
***************


[1] - https://gn-review.googlesource.com/c/gn/+/6860

Bug: webrtc:11302
Change-Id: Ia39387d089a0c56a2c3ad9a7264c20eb5a38ac93
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166535
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30331}
5 files changed
tree: de6e2c27176594b436ad0412b1f358c1987d55da
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. logging/
  11. media/
  12. modules/
  13. p2p/
  14. pc/
  15. resources/
  16. rtc_base/
  17. rtc_tools/
  18. sdk/
  19. stats/
  20. style-guide/
  21. system_wrappers/
  22. test/
  23. tools_webrtc/
  24. video/
  25. .clang-format
  26. .git-blame-ignore-revs
  27. .gitignore
  28. .gn
  29. .vpython
  30. abseil-in-webrtc.md
  31. AUTHORS
  32. BUILD.gn
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. common_types.h
  36. DEPS
  37. ENG_REVIEW_OWNERS
  38. LICENSE
  39. license_template.txt
  40. native-api.md
  41. OWNERS
  42. PATENTS
  43. PRESUBMIT.py
  44. presubmit_test.py
  45. presubmit_test_mocks.py
  46. pylintrc
  47. README.chromium
  48. README.md
  49. style-guide.md
  50. WATCHLISTS
  51. webrtc.gni
  52. webrtc_lib_link_test.cc
  53. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info