commit | b92f9856b5857bef85735d9f8651f329de220ad1 | [log] [tgz] |
---|---|---|
author | Taylor Brandstetter <deadbeef@webrtc.org> | Thu Aug 05 21:02:43 2021 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Aug 06 19:53:09 2021 |
tree | 86f2af9020a8950f2881e43cbdf424fc772ec0f0 | |
parent | 7b78a3142d88cdc09d49562f420fc11ce25fbf71 [diff] |
Revert "Reland "Fix bug where we assume new m= sections will always be bundled."" This reverts commit 704a834f685eb96c9fcf891ca345557bef4d138a. Reason for revert: Reverting this in order to revert https://webrtc-review.googlesource.com/c/src/+/221601, so we can merge that revert to M93. Original change's description: > Reland "Fix bug where we assume new m= sections will always be bundled." > > This is a reland of d2b885fd91909f1b17fb11292a8c989d5d883b22, after > making sure transports that are just being kept alive in case of > rollback don't contribute to connection state, which broke a WPT. > > Original change's description: > > Fix bug where we assume new m= sections will always be bundled. > > > > A recent change [1] assumes that all new m= sections will share the > > first BUNDLE group (if one already exists), which avoids generating > > ICE candidates that are ultimately unnecessary. This is fine for JSEP > > endpoints, but it breaks the following scenarios for non-JSEP endpoints: > > > > * Remote offer adding a new m= section that's not part of any BUNDLE > > group. > > * Remote offer adding an m= section to the second BUNDLE group. > > > > The latter is specifically problematic for any application that wants > > to bundle all audio streams in one group and all video streams in > > another group when using Unified Plan SDP, to replicate the behavior of > > using Plan B without bundling. It may try to add a video stream only > > for WebRTC to bundle it with audio. > > > > This is fixed by doing some minor re-factoring, having BundleManager > > update the bundle groups at offer time. > > > > Also: > > * Added some additional validation for multiple bundle groups in a > > subsequent offer, since that now becomes relevant. > > * Improved rollback support, because now rolling back an offer may need > > to not only remove mid->transport mappings but alter them. > > > > [1]: https://webrtc-review.googlesource.com/c/src/+/221601 > > > > Bug: webrtc:12906, webrtc:12999 > > Change-Id: I4c6e7020c0be33a782d3608dee88e4e2fceb1be1 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225642 > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Henrik Boström <hbos@webrtc.org> > > Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#34544} > > Bug: webrtc:12906, webrtc:12999 > Change-Id: I68bf988b1918dd2d51de76e53e4fd696fea5a09b > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227120 > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#34596} TBR=hta@webrtc.org Bug: webrtc:12906, webrtc:12999 Change-Id: I129d9eb3b9831317fa24b0263db191027246cb99 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227821 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34666}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.