commit | bb917acb10ddc9e131eec5efb352c45cee850840 | [log] [tgz] |
---|---|---|
author | henrika <henrika@webrtc.org> | Mon Jun 19 14:36:29 2023 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 19 14:39:39 2023 |
tree | e4ed44132c03484803d52b67494681afdb59711e | |
parent | b4969d0036fff0ed22825700d874b97c4a0ead55 [diff] |
Fixes crash in WgcCaptureSession::ProcessFrame This change fixes a minor issue where we previosuly assumed that the following was true: RTC_DCHECK_EQ(map_info.RowPitch, current_frame->stride()) It turns out that this is not always the case when sharing a window where the stride can sometimes be a few bytes smaller than the rowpitch. The code is behind a command-line flag and no tests are affected. Given limited review resources I therefore plan to bypass the CQ. I know that it is not recommended but the change has been tested locally on two different Windows platforms and it does avoid an existing crash. Code-Review: alcooper@chromium.org No-Try: true Bug: chromium:1421242 Change-Id: I01e7105a6f9fca7ce1349a57635dd373c28d160b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309342 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40308}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.