Google Git
Sign in
webrtc / src / fa8a9465d50d516745fc353ba2ebb80f34b622fb
commitfa8a9465d50d516745fc353ba2ebb80f34b622fb[log] [tgz]
authorHenrik Boström <hbos@webrtc.org>Thu Apr 15 08:44:00 2021
committerCommit Bot <commit-bot@chromium.org>Thu Apr 15 10:18:40 2021
tree884f0386e0ae0f3fc8af12c09f8bc617f85c681f
parent17490b53d230f5286af92a2be5638ecad438711b [diff]
Remove obsolete DCHECK in remote_audio_source.cc.

When fixing so that RemoteAudioSource does not end the track just
because the audio channel is gone in Unified Plan[1], this made it
possible for ~PeerConnection to delete all objects, including deleting
the MediaStreamTrack and its RemoteAudioSource, when all tracks are not
in an ended state.

In a real application or Chromium, the PeerConnection would not be
destroyed prior to closing and not hit this DCHECK. But in upstream
dependent projects' unit tests, it would be possible for ref counted
tracks to be destroyed when the track are still kLive, and as a
side-effect hit this DCHECK.

sinks_ is just a list of raw pointers, and whether or not we have done
sinks_.clear() prior to destruction is irrelevant going forward.

[1] https://webrtc-review.googlesource.com/c/src/+/214136

Bug: chromium:1121454
Change-Id: If6cf3dffcd3cb47d46694755b5dc45fa381285fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215226
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33739}
1 file changed
tree: 884f0386e0ae0f3fc8af12c09f8bc617f85c681f
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. g3doc/
  11. logging/
  12. media/
  13. modules/
  14. net/
  15. p2p/
  16. pc/
  17. resources/
  18. rtc_base/
  19. rtc_tools/
  20. sdk/
  21. stats/
  22. style-guide/
  23. system_wrappers/
  24. test/
  25. tools_webrtc/
  26. video/
  27. .clang-format
  28. .git-blame-ignore-revs
  29. .gitignore
  30. .gn
  31. .vpython
  32. abseil-in-webrtc.md
  33. AUTHORS
  34. BUILD.gn
  35. CODE_OF_CONDUCT.md
  36. codereview.settings
  37. DEPS
  38. DIR_METADATA
  39. ENG_REVIEW_OWNERS
  40. g3doc.lua
  41. LICENSE
  42. license_template.txt
  43. native-api.md
  44. OWNERS
  45. PATENTS
  46. PRESUBMIT.py
  47. presubmit_test.py
  48. presubmit_test_mocks.py
  49. pylintrc
  50. README.chromium
  51. README.md
  52. style-guide.md
  53. WATCHLISTS
  54. webrtc.gni
  55. webrtc_lib_link_test.cc
  56. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info