commit bfd9ba8802be081a9a5201d7afb6284b3954cdff
author Tomas Gunnarsson <tommi@webrtc.org> Sun Apr 18 09:55:57 2021
committer Commit Bot <commit-bot@chromium.org> Mon Apr 19 16:22:23 2021
tree c4311557907bfbe0bba6c418bf28648d91469de5
parent f703ed1e247d411d2480e0447f4bb63f3784ab0c

Fix unsafe variable access in RTCStatsCollector

With this change, all production callers of BaseChannel::transport_name()
will be making the call from the right thread and we can safely delegate
the call to the transport itself. Some tests still need to be updated.
This facilitates the main goal of not needing synchronization inside
of the channel classes, being able to apply thread checks and eventually
remove thread hops from the channel classes.

A downside of this particular change is that a blocking call to the
network thread from the signaling thread inside of RTCStatsCollector
needs to be done. This is done once though and fixes a race.

Bug: webrtc:12601, webrtc:11687, webrtc:12644
Change-Id: I85f34f3341a06da9a9efd936b1d36722b10ec487
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213080
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33775}