commit c09b14c3c57d521416a57dde57bf969cbf41ac17
author Florent Castelli <orphis@webrtc.org> Tue Nov 16 11:50:13 2021
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 16 12:59:20 2021
tree b91749d7d7039c1336025ad2ade56a057c15541b
parent 4cbfe4192cd5b8289f7896ce14e0bd8c4ae41a97

Use a FQDN hostname as an invalid hostname

On some networks, it's possible to have a DNS search domain pushed that
might make what is an invalid hostname succeed a DNS query.
In this case, invalid.com has a wildcard DNS entry and it would make this
test fail. Using a FQDN instead prevents search domains from being used.

Bug: none
Change-Id: I013f012db147b9c428b18d60e94a615153f199a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237810
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35355}

p2p/base/turn_port_unittest.cc

diff --git a/p2p/base/turn_port_unittest.cc b/p2p/base/turn_port_unittest.cc
index e441657..f16a5b8 100644
--- a/p2p/base/turn_port_unittest.cc
+++ b/p2p/base/turn_port_unittest.cc
@@ -76,7 +76,7 @@
 static const SocketAddress kTurnUdpIPv6IntAddr(
     "2400:4030:1:2c00:be30:abcd:efab:cdef",
     cricket::TURN_SERVER_PORT);
-static const SocketAddress kTurnInvalidAddr("www.google.invalid", 3478);
+static const SocketAddress kTurnInvalidAddr("www.google.invalid.", 3478);
 
 static const char kCandidateFoundation[] = "foundation";
 static const char kIceUfrag1[] = "TESTICEUFRAG0001";
@@ -1625,8 +1625,7 @@
   int last_fd_count = GetFDCount();
   // Need to supply unresolved address to kick off resolver.
   CreateTurnPort(kLocalIPv6Addr, kTurnUsername, kTurnPassword,
-                 ProtocolAddress(rtc::SocketAddress("www.google.invalid", 3478),
-                                 PROTO_UDP));
+                 ProtocolAddress(kTurnInvalidAddr, PROTO_UDP));
   turn_port_->PrepareAddress();
   ASSERT_TRUE_WAIT(turn_error_, kResolverTimeout);
   EXPECT_TRUE(turn_port_->Candidates().empty());