commit c32df1e84939e07ca5e1296d4ee8d69dea3f3321
author Philipp Hancke <phancke@meta.com> Wed Oct 02 21:19:19 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 03 06:05:08 2024
tree 399d873347cd551e344323f1dc2e52a642d0fab8
parent c59b76affb3eef9387e8145a50723cd71af79875

Clean up unused sigslot dependency from OpenSSL stream adapter

BUG=webrtc:339300437,webrtc:42222066

Change-Id: I3efe104d7c65f516a8e6dd0034b2e0234db5748d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364540
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#43153}

rtc_base/BUILD.gn

diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn
index 1dace8a..804d7ae 100644
--- a/rtc_base/BUILD.gn
+++ b/rtc_base/BUILD.gn
@@ -1619,7 +1619,6 @@
     "../system_wrappers:field_trial",
     "system:rtc_export",
     "task_utils:repeating_task",
-    "third_party/sigslot",
     "//third_party/abseil-cpp/absl/functional:any_invocable",
     "//third_party/abseil-cpp/absl/memory",
     "//third_party/abseil-cpp/absl/strings",

rtc_base/openssl_stream_adapter.h

diff --git a/rtc_base/openssl_stream_adapter.h b/rtc_base/openssl_stream_adapter.h
index 7ad50c6..a776c1a 100644
--- a/rtc_base/openssl_stream_adapter.h
+++ b/rtc_base/openssl_stream_adapter.h
@@ -25,7 +25,8 @@
 #include "api/array_view.h"
 #include "rtc_base/buffer.h"
 #ifdef OPENSSL_IS_BORINGSSL
-#include "openssl/base.h"
+#include <openssl/base.h>
+
 #include "rtc_base/boringssl_identity.h"
 #else
 #include "rtc_base/openssl_identity.h"
@@ -35,7 +36,6 @@
 #include "rtc_base/ssl_stream_adapter.h"
 #include "rtc_base/stream.h"
 #include "rtc_base/task_utils/repeating_task.h"
-#include "rtc_base/third_party/sigslot/sigslot.h"
 #include "rtc_base/thread.h"
 
 namespace rtc {
@@ -62,14 +62,11 @@
 // and it has an explicit SSL_CLOSED state. It should not be possible to send
 // any data in clear after one of the StartSSL methods has been called.
 
-// Look in sslstreamadapter.h for documentation of the methods.
-
-class SSLCertChain;
+// Look in ssl_stream_adapter.h for documentation of the methods.
 
 ///////////////////////////////////////////////////////////////////////////////
 
-class OpenSSLStreamAdapter final : public SSLStreamAdapter,
-                                   public sigslot::has_slots<> {
+class OpenSSLStreamAdapter final : public SSLStreamAdapter {
  public:
   OpenSSLStreamAdapter(
       std::unique_ptr<StreamInterface> stream,