Google Git
Sign in
webrtc / src / c3da1e61bccf4c6a37e871f5202f937ace78898a
commitc3da1e61bccf4c6a37e871f5202f937ace78898a[log] [tgz]
authorMirko Bonadei <mbonadei@webrtc.org>Tue Dec 05 10:25:29 2017
committerCommit Bot <commit-bot@chromium.org>Tue Dec 05 11:58:32 2017
tree528249518c9054f6e3f015735caa27776ef28cdc
parent4f6b6c2437a0b7290275f5b45407dd788570ccba [diff]
Fixing chromium MSVC64(dbg) build.

CL https://webrtc-review.googlesource.com/c/src/+/28120 removed a
public dependency from rtc_tools:video_quality_analysis on
common_video:common_video.

This was keeping the MSVC64(dbg) build green because was giving the
linker the opportunity to find api:optional symbols.

This CL tries to fix and adds a TODO to remove the synthetic
dependency. The dependency on api:optional should be added to
rtc_base:rtc_base_approved_generic but this triggers another
dependency cycle.

TBR=tommi@webrtc.org

Bug: webrtc:6828
Change-Id: I4e28b49fdb3ee6484a253ca7b1f1a8aafa20e915
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/29683
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21079}
1 file changed
tree: 528249518c9054f6e3f015735caa27776ef28cdc
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. examples/
  9. infra/
  10. logging/
  11. media/
  12. modules/
  13. ortc/
  14. p2p/
  15. pc/
  16. resources/
  17. rtc_base/
  18. rtc_tools/
  19. sdk/
  20. stats/
  21. system_wrappers/
  22. test/
  23. tools_webrtc/
  24. video/
  25. voice_engine/
  26. .clang-format
  27. .git-blame-ignore-revs
  28. .gitignore
  29. .gn
  30. .vpython
  31. AUTHORS
  32. BUILD.gn
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. common_types.cc
  36. common_types.h
  37. DEPS
  38. LICENSE
  39. license_template.txt
  40. LICENSE_THIRD_PARTY
  41. native-api.md
  42. OWNERS
  43. PATENTS
  44. PRESUBMIT.py
  45. presubmit_test.py
  46. presubmit_test_mocks.py
  47. pylintrc
  48. README.chromium
  49. README.md
  50. style-guide.md
  51. typedefs.h
  52. WATCHLISTS
  53. webrtc.gni
  54. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info