commit | c4f9824cee43d32cb6296d7d58c8bfb8951f0f0e | [log] [tgz] |
---|---|---|
author | Lu Liu <lliuu@webrtc.org> | Wed Feb 21 19:37:14 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 21 19:37:21 2018 |
tree | 4523521d8b4b3cddff0e96b86ce14f10077b973d | |
parent | cf6e24a12d30c6a64d8925ad03218f6bc1014343 [diff] |
Revert "Reduce locking in VideoReceiver and check the threading model." This reverts commit c75f1e45093a8d5cc62937c7708b87aa5c5bf0b0. Reason for revert: Breaking internal project Original change's description: > Reduce locking in VideoReceiver and check the threading model. > > Note: This is a subset of code that was previously reviewed here: > - https://codereview.webrtc.org/2764573002/ > > * Added two notification methods, DecoderThreadStarting() and DecoderThreadStopped() > * Allows us to establish a period when the decoder thread is not running and it is > safe to modify variables such as callbacks, that are only read when the decoder > thread is running. > * Allows us to DCHECK thread guarantees/correctness. > * Allows synchronizing callbacks from the module process thread and have them only > active while the decoder thread is running. > * The above, allows us to establish two modes for the thread, > single-threaded-mutable and multi-threaded-const. > * Using that knowledge, we can remove |receive_crit_| as well as locking for a > number of member variables. > * Removed |VCMFrameBuffer _frameFromFile| (unused). > * Clean up several of my TODOs > > Bug: webrtc:7361, chromium:695438 > Change-Id: Id0048ee9624f76103c088d02825eb5c0d6c8913c > Reviewed-on: https://webrtc-review.googlesource.com/55000 > Commit-Queue: Tommi <tommi@webrtc.org> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22133} TBR=tommi@webrtc.org,philipel@webrtc.org Change-Id: I4d78e8b2c05b36e1a3f64cb38d652579b3a23f22 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:7361, chromium:695438 Reviewed-on: https://webrtc-review.googlesource.com/56280 Reviewed-by: Lu Liu <lliuu@webrtc.org> Commit-Queue: Lu Liu <lliuu@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22141}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.