commit | c5b8c8f36b6ba20283074870ef4bdea0e1f51970 | [log] [tgz] |
---|---|---|
author | Austin Orion <auorion@microsoft.com> | Fri May 06 22:53:30 2022 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 06 23:46:42 2022 |
tree | 8ec1b1db5ad4abc5bb190228feb2ccb3bdf7a4a5 | |
parent | c48ad732d6eb69f14dd6d44f801d62997cef2c2f [diff] |
Fix failing WGC tests on Win10 Several tests starting failing when run on trybots on Win10. This CL fixes several issues that were uncovered. Issue 1: Capture failed to start because `get_Size` returned {0, 0}. This is a known issue in the WGC API that occurs when there are multiple user sessions on the same machine. Solution: Add a `GetSize` method to the `WgcCaptureSource` interface so we can fallback to other methods if `get_Size` fails. Issue 2: The screen capture tests assume there will be displays attached and fail if there aren't. Solution: Always run `IsWgcSupported` for the appropriate capture type. Issue 3: ASAN container-overflow in `GetTestWindowIdFromSourceList` Solution: Check the validity of the iterator before dereferencing. Issue 4: Occasionally, the call to `GetMessage` in the `CloseWindowMidCapture` test would hang because there were no messages in the queue. Solution: Use `PeekMessage` instead which will return if there are no messages. Bug: webrtc:14002 Change-Id: I69b2f765db87d34a41d6a1796cd5a81f4029be33 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260202 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Austin Orion <auorion@microsoft.com> Cr-Commit-Position: refs/heads/main@{#36802}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.