commit c80e741ad0ab8348a45eddd451e95607689b6c22
author nisse <nisse@webrtc.org> Wed Jan 11 13:56:46 2017
committer Commit bot <commit-bot@chromium.org> Wed Jan 11 13:56:46 2017
tree 1d1a476f244478e83089fe553becaa403b8e2563
parent 10418acb9790a82aa8f8368c8d6ba2459747149b

Replace ASSERT(false) by RTC_NOTREACHED().

This cl was produced by

  git grep -l 'ASSERT(false)' |\
    xargs -n1 sed -i 's/ASSERT(false)/RTC_NOTREACHED()/'

followed by additional includes of base/checks.h in affected files,
git cl format to adjust spacing in webrtc/base/transformadapter.cc.
Finally, to make presubmit happy, one unnamed TODO marker was deleted
in that file.

This is a step towards deletion of base/common.h.

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2625003003
Cr-Commit-Position: refs/heads/master@{#16009}

webrtc/base/physicalsocketserver.cc

diff --git a/webrtc/base/physicalsocketserver.cc b/webrtc/base/physicalsocketserver.cc
index bf2f2c6..5efc1a6 100644
--- a/webrtc/base/physicalsocketserver.cc
+++ b/webrtc/base/physicalsocketserver.cc
@@ -42,6 +42,7 @@
 #include "webrtc/base/arraysize.h"
 #include "webrtc/base/basictypes.h"
 #include "webrtc/base/byteorder.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/common.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/networkmonitor.h"
@@ -479,7 +480,7 @@
     }
   }
 
-  ASSERT(false);
+  RTC_NOTREACHED();
   return -1;
 #elif defined(WEBRTC_MAC)
   // No simple way to do this on Mac OS X.
@@ -595,7 +596,7 @@
     case OPT_RTP_SENDTIME_EXTN_ID:
       return -1;  // No logging is necessary as this not a OS socket option.
     default:
-      ASSERT(false);
+      RTC_NOTREACHED();
       return -1;
   }
   return 0;
@@ -854,7 +855,7 @@
     }
   }
 
-  void OnEvent(uint32_t ff, int err) override { ASSERT(false); }
+  void OnEvent(uint32_t ff, int err) override { RTC_NOTREACHED(); }
 
   int GetDescriptor() override { return afd_[0]; }
 
@@ -1499,7 +1500,7 @@
       // Failed?
       // TODO(pthatcher): need a better strategy than this!
       WSAGetLastError();
-      ASSERT(false);
+      RTC_NOTREACHED();
       return false;
     } else if (dw == WSA_WAIT_TIMEOUT) {
       // Timeout?