| commit | d2b5b1f5bae94c24cc279fe198ff28236821f1ac | [log] [tgz] |
|---|---|---|
| author | Alex Loiko <aleloi@webrtc.org> | Wed Jan 24 13:20:17 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 24 14:26:28 2018 |
| tree | 2e57b75a3c91898448e5f189f7982f72ea5a5a9b | |
| parent | 53a2d8a6c70d242caf5878d1fd004148908e16ac [diff] |
Division by zero in NoiseSuppression. This change handles a special case in NoiseSuppression. The special case was found by the AudioProcessing fuzzer. A const copy of the capture audio stream is sent to NoiseSuppression::AnalyzeCaptureAudio. Then audio undergoes processing by e.g. the echo canceller. Then it's processed by NoiseSuppression::ProcessCaptureAudio. The special case is when the following conditions are all satisfied: * All stream samples are constantly zero in the call to AnalyzeCaptureAudio * a processing component modifies it to be nonzero before the call to ProcessCaptureAudio * The array NoiseSuppressionC::magnPrevAnalyze is filled with zeros. This holds after initialization. In this case, there is a division by zero in WebRtcNs_ProcessCore. The resulting NaN values pollute the output signal. They are only detected several submodules later in the process chain. The NaN values cause the EchoDetector to crash in debug mode. There is special handling of the case when the signal is constant zero in ProcessCore. This change avoids zero division by handling this issue the same way. Bug: chromium:803810 chromium:804634 Change-Id: I6d698dd0cd27e6d550b42085124300ce58533125 Reviewed-on: https://webrtc-review.googlesource.com/41282 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21745}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.