AEC3: Fix render buffer headroom calculation on underruns

The read and write pointers can meet. Currently, this causes an overflow in the headroom calculation (headroom == buffer size) which offsets the buffers needlessly. This causes a loss of transparency when using the neural residual echo estimation module.

Tested:
  1. audioproc_f is bitexact on a large set of aecdumps, without ML-REE
  2. I see improved transparency on a dump with underruns, with ML-REE

Bug: b:487988676, webrtc:442444736
Change-Id: I902a20f28c603f85a1c10ae5b525788e3a54c285
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/456301
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#47153}
1 file changed
tree: 665048fcbdf49e0cd7f3ab5de1f2c8e9dd0c2376
  1. agents/
  2. api/
  3. audio/
  4. build_overrides/
  5. call/
  6. common_audio/
  7. common_video/
  8. data/
  9. docs/
  10. examples/
  11. experiments/
  12. g3doc/
  13. infra/
  14. logging/
  15. media/
  16. modules/
  17. net/
  18. p2p/
  19. pc/
  20. resources/
  21. rtc_base/
  22. rtc_tools/
  23. sdk/
  24. stats/
  25. system_wrappers/
  26. test/
  27. tools_webrtc/
  28. video/
  29. .clang-format
  30. .clang-tidy
  31. .git-blame-ignore-revs
  32. .gitignore
  33. .gn
  34. .mailmap
  35. .rustfmt.toml
  36. .style.yapf
  37. .vpython3
  38. AUTHORS
  39. BUILD.gn
  40. CODE_OF_CONDUCT.md
  41. codereview.settings
  42. DEPS
  43. DIR_METADATA
  44. ENG_REVIEW_OWNERS
  45. GEMINI.md
  46. LICENSE
  47. license_template.txt
  48. native-api.md
  49. OWNERS
  50. OWNERS_INFRA
  51. PATENTS
  52. PRESUBMIT.py
  53. presubmit_test.py
  54. presubmit_test_mocks.py
  55. pylintrc
  56. pylintrc_old_style
  57. README.chromium
  58. README.md
  59. unsafe_buffers_paths.txt
  60. WATCHLISTS
  61. webrtc.gni
  62. webrtc_lib_link_test.cc
  63. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info