| commit | d6e9466e7ef8736c5dd4c736c9732506b1b70c1e | [log] [tgz] |
|---|---|---|
| author | eladalon <eladalon@webrtc.org> | Wed Jun 28 14:31:30 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 28 14:31:30 2017 |
| tree | 922f7cdac8e8c5566846eb2950e134394f82f6e8 | |
| parent | 3d0e7bb90710bdeacccf1611967621e4d6e55f26 [diff] |
No compliation-flag-dependent members in CriticalSection Having members in a class which only exist when certain compliation flags are turned on (unless relating to the target platform) means that those flags must be the same when compiling the module as when including its headers from other modules. This means that code outside of WebRTC runs the risk of misjudging the size of an rtc::CriticalSection, or any class which has an rtc::CriticalSection as a member. (This rule is applied recursively.) If a mismatch occurs, memory corruption is likely. Having discussed this a bit, we have decided that the simplest solution is probably the best - always define those members, even when compilation flags (namely, CS_DEBUG_CHECKS) render it unused. BUG=webrtc:7867 Review-Url: https://codereview.webrtc.org/2957753002 Cr-Commit-Position: refs/heads/master@{#18811}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.