commit d95382fab7dcac8867d9811c4630367c4454cb7d
author Tommi <tommi@webrtc.org> Thu Aug 24 23:12:04 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 30 18:15:30 2023
tree 636e658758f3f30351e198a427073af0b95ef094
parent 82e5f91a2bdf955aa870142008fbdc9ac12f6acd

[M117][SctpDataChannel] Don't use PostTask for observer registration.

Instead, use BlockingCall to match with how unregistration is done.
This is needed because the ThreadWrapper implementation in Chromium, overriding the Thread implementation in WebRTC, does not order sent (blocking) tasks along with posted tasks.

That makes the functional difference that Thread1 posting and sending
tasks to Thread2, can not assume that the tasks run in the order they
were posted and sent. I.e. in this case:

  // Running on Thread1.
  thread2->PostTask([](){ Foo(); });
  thread2->BlockingCall([](){ Bar(); });

Thread2 may actually execute Bar() first, and then Foo().

(cherry picked from commit 70cea9bda8b8815be3c5bae4b6fa8053713efcac)

No-Try: true
Bug: chromium:1470992
Change-Id: I1f83f12ce39c09279c0f2b3bc71c3a33e2cb16c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/317700
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#40624}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/318360
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/branch-heads/5938@{#1}
Cr-Branched-From: 82e5f91a2bdf955aa870142008fbdc9ac12f6acd-refs/heads/main@{#40524}