Disabling crashing or flaky tests in peerconnection_unittest.
R=kjellander@webrtc.org
TBR=wu@webrtc.org
TESTS=trybots
BUG=2378
Review URL: https://webrtc-codereview.appspot.com/2227004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4767 4adac7df-926f-26a2-2b94-8c16560cd09d
diff --git a/talk/app/webrtc/peerconnection_unittest.cc b/talk/app/webrtc/peerconnection_unittest.cc
index b3cf0f5..522d528 100644
--- a/talk/app/webrtc/peerconnection_unittest.cc
+++ b/talk/app/webrtc/peerconnection_unittest.cc
@@ -990,7 +990,9 @@
typedef P2PTestConductor<JsepTestClient> JsepPeerConnectionP2PTestClient;
// This test sets up a Jsep call between two parties and test Dtmf.
-TEST_F(JsepPeerConnectionP2PTestClient, LocalP2PTestDtmf) {
+// TODO(holmer): Disabled due to sometimes crashing on buildbots.
+// See issue webrtc/2378.
+TEST_F(JsepPeerConnectionP2PTestClient, DISABLED_LocalP2PTestDtmf) {
ASSERT_TRUE(CreateTestClients());
LocalP2PTest();
VerifyDtmf();
@@ -1370,7 +1372,10 @@
// This test sets up a Jsep call between two parties with external
// VideoDecoderFactory.
-TEST_F(JsepPeerConnectionP2PTestClient, LocalP2PTestWithVideoDecoderFactory) {
+// TODO(holmer): Disabled due to sometimes crashing on buildbots.
+// See issue webrtc/2378.
+TEST_F(JsepPeerConnectionP2PTestClient,
+ DISABLED_LocalP2PTestWithVideoDecoderFactory) {
ASSERT_TRUE(CreateTestClients());
EnableVideoDecoderFactory();
LocalP2PTest();
diff --git a/talk/p2p/base/p2ptransportchannel_unittest.cc b/talk/p2p/base/p2ptransportchannel_unittest.cc
index 4617179..1527b70 100644
--- a/talk/p2p/base/p2ptransportchannel_unittest.cc
+++ b/talk/p2p/base/p2ptransportchannel_unittest.cc
@@ -1022,13 +1022,15 @@
#define FLAKY_P2P_TEST(x, y) \
P2P_TEST_DECLARATION(x, y, DISABLED_)
+// TODO(holmer): Disabled due to randomly failing on webrtc buildbots.
+// Issue: webrtc/2383
#define P2P_TEST_SET(x) \
P2P_TEST(x, OPEN) \
- P2P_TEST(x, NAT_FULL_CONE) \
+ FLAKY_P2P_TEST(x, NAT_FULL_CONE) \
P2P_TEST(x, NAT_ADDR_RESTRICTED) \
P2P_TEST(x, NAT_PORT_RESTRICTED) \
P2P_TEST(x, NAT_SYMMETRIC) \
- P2P_TEST(x, NAT_DOUBLE_CONE) \
+ FLAKY_P2P_TEST(x, NAT_DOUBLE_CONE) \
P2P_TEST(x, NAT_SYMMETRIC_THEN_CONE) \
P2P_TEST(x, BLOCK_UDP) \
P2P_TEST(x, BLOCK_UDP_AND_INCOMING_TCP) \
diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-tsan.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-tsan.txt
index e67d2d8..3adb629 100644
--- a/tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-tsan.txt
+++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-tsan.txt
@@ -27,3 +27,296 @@
PeerConnectionInterfaceTest.TestSendOnlyDataChannel
WebRtcSessionTest.TestRtpDataChannelConstraintTakesPrecedence
WebRtcSessionTest.TestSctpDataChannelWithDtls
+
+# The following disables all tests under tsan due to crashes on shutdown.
+SctpDataChannelTest..*
+BufferedAmountWhenBlocked.*
+QueuedDataSentWhenUnblocked.*
+DtmfSenderTest..*
+CanInsertDtmf.*
+InsertDtmf.*
+InsertDtmfTwice.*
+InsertDtmfWhileProviderIsDeleted.*
+InsertDtmfWhileSenderIsDeleted.*
+InsertEmptyTonesToCancelPreviousTask.*
+InsertDtmfWithCommaAsDelay.*
+TryInsertDtmfWhenItDoesNotWork.*
+InsertDtmfWithInvalidDurationOrGap.*
+JsepSessionDescriptionTest..*
+CheckSessionDescription.*
+AddCandidateWithoutMid.*
+AddCandidateWithMid.*
+AddCandidateAlreadyHasUfrag.*
+AddBadCandidate.*
+SerializeDeserialize.*
+SerializeDeserializeWithCandidates.*
+LocalAudioSourceTest..*
+SetValidOptions.*
+OptionNotSet.*
+MandatoryOverridesOptional.*
+InvalidOptional.*
+InvalidMandatory.*
+LocalVideoSourceTest..*
+StartStop.*
+CameraFailed.*
+MandatoryConstraintCif5Fps.*
+MandatoryMinVgaOptional720P.*
+MandatoryAspectRatio4To3.*
+MandatoryAspectRatioTooHigh.*
+OptionalAspectRatioTooHigh.*
+NoCameraCapability.*
+NoCameraCapability16To9Ratio.*
+InvalidMandatoryConstraint.*
+InvalidOptionalConstraint.*
+SetValidOptionValues.*
+OptionNotSet.*
+MandatoryOptionOverridesOptional.*
+InvalidOptionKeyOptional.*
+InvalidOptionKeyMandatory.*
+InvalidOptionValueOptional.*
+InvalidOptionValueMandatory.*
+MixedOptionsAndConstraints.*
+ScreencastResolutionNoConstraint.*
+ScreencastResolutionWithConstraint.*
+MandatorySubOneFpsConstraints.*
+OptionalSubOneFpsConstraints.*
+MediaStreamSignalingTest..*
+GetMediaSessionOptionsForOfferWithAudioVideo.*
+GetMediaSessionOptionsForOfferWithAudio.*
+GetDefaultMediaSessionOptionsForOffer.*
+GetMediaSessionOptionsForOfferWithVideo.*
+GetMediaSessionOptionsForOfferWithBundleDisabled.*
+GetMediaSessionOptionsForOfferWithIceRestart.*
+GetMediaSessionOptionsWithBadConstraints.*
+AddTrackToLocalMediaStream.*
+MediaConstraintsInAnswer.*
+UpdateRemoteStreams.*
+AddRemoveTrackFromExistingRemoteMediaStream.*
+RejectMediaContent.*
+RemoveTrackThenRejectMediaContent.*
+SdpWithoutMsidCreatesDefaultStream.*
+RemoveAlreadyGoneRemoteStream.*
+SdpWithoutMsidAndStreamsCreatesDefaultStream.*
+SdpWitMsidDontCreatesDefaultStream.*
+VerifyDefaultStreamIsNotCreated.*
+LocalDescriptionChanged.*
+AddLocalStreamAfterLocalDescriptionChanged.*
+ChangeSsrcOnTrackInLocalSessionDescription.*
+JsepPeerConnectionP2PTestClient..*
+DISABLED_LocalP2PTestDtmf.*
+LocalP2PTest16To9.*
+DISABLED_LocalP2PTest1280By720.*
+LocalP2PTestDtls.*
+LocalP2PTestOfferDtlsToSdes.*
+LocalP2PTestOfferSdesToDtls.*
+LocalP2PTestOfferDtlsButNotSdes.*
+DISABLED_LocalP2PTestAnswerVideo.*
+DISABLED_LocalP2PTestAnswerAudio.*
+LocalP2PTestAnswerNone.*
+UpdateOfferWithRejectedContent.*
+LocalP2PTestWithoutMsid.*
+DISABLED_LocalP2PTestTwoStreams.*
+GetAudioOutputLevelStats.*
+GetAudioInputLevelStats.*
+GetBytesReceivedStats.*
+GetBytesSentStats.*
+LocalP2PTestDataChannel.*
+RegisterDataChannelObserver.*
+LocalP2PTestReceiverDoesntSupportData.*
+AddDataChannelAfterRenegotiation.*
+IceRestart.*
+DISABLED_LocalP2PTestWithVideoDecoderFactory.*
+PeerConnectionFactoryTestInternal..*
+CreatePCUsingInternalModules.*
+PeerConnectionFactoryTest..*
+CreatePCUsingIceServers.*
+CreatePCUsingNoUsernameInUri.*
+CreatePCUsingTurnUrlWithTransportParam.*
+CreatePCUsingSecureTurnUrl.*
+LocalRendering.*
+PeerConnectionInterfaceTest..*
+CreatePeerConnectionWithDifferentConfigurations.*
+AddStreams.*
+RemoveStream.*
+CreateOfferReceiveAnswer.*
+CreateOfferReceivePrAnswerAndAnswer.*
+ReceiveOfferCreateAnswer.*
+ReceiveOfferCreatePrAnswerAndAnswer.*
+Renegotiate.*
+RenegotiateAudioOnly.*
+IceCandidates.*
+CreateOfferAnswerWithInvalidStream.*
+SsrcInOfferAnswer.*
+GetStatsForSpecificTrack.*
+GetStatsForVideoTrack.*
+GetStatsForInvalidTrack.*
+TestDataChannel.*
+TestSendBinaryOnRtpDataChannel.*
+TestSendOnlyDataChannel.*
+TestReceiveOnlyDataChannel.*
+CreateReliableRtpDataChannelShouldFail.*
+CreateSctpDataChannel.*
+CreateSctpDataChannelShouldFailForInvalidConfig.*
+AssignSctpDataChannelId.*
+CreateSctpDataChannelWithInvalidIdShouldFail.*
+DataChannelCloseWhenPeerConnectionClose.*
+TestRejectDataChannelInAnswer.*
+ReceiveFireFoxOffer.*
+ReceiveUpdatedAudioOfferWithBadCodecs.*
+CloseAndTestStreamsAndStates.*
+CloseAndTestMethods.*
+CloseAndGetStats.*
+FakeAdmTest..*
+TestProccess.*
+PlayoutTest.*
+RecordTest.*
+DuplexTest.*
+VideoTrack..*
+RenderVideo.*
+WebRtcSdpTest..*
+SerializeSessionDescription.*
+SerializeSessionDescriptionEmpty.*
+SerializeSessionDescriptionWithFingerprint.*
+SerializeSessionDescriptionWithFingerprintNoCryptos.*
+SerializeSessionDescriptionWithoutCandidates.*
+SerializeSessionDescriptionWithBundle.*
+SerializeSessionDescriptionWithBandwidth.*
+SerializeSessionDescriptionWithIceOptions.*
+SerializeSessionDescriptionWithRecvOnlyContent.*
+SerializeSessionDescriptionWithSendOnlyContent.*
+SerializeSessionDescriptionWithInactiveContent.*
+SerializeSessionDescriptionWithAudioRejected.*
+SerializeSessionDescriptionWithVideoRejected.*
+SerializeSessionDescriptionWithAudioVideoRejected.*
+SerializeSessionDescriptionWithRtpDataChannel.*
+SerializeSessionDescriptionWithSctpDataChannel.*
+SerializeSessionDescriptionWithDataChannelAndBandwidth.*
+SerializeSessionDescriptionWithExtmap.*
+SerializeCandidates.*
+DeserializeSessionDescription.*
+DeserializeSessionDescriptionWithoutCarriageReturn.*
+DeserializeSessionDescriptionWithoutCandidates.*
+DeserializeSessionDescriptionWithoutRtpmap.*
+DeserializeJsepSessionDescriptionWithFingerprint.*
+DeserializeSessionDescriptionWithBundle.*
+DeserializeSessionDescriptionWithBandwidth.*
+DeserializeSessionDescriptionWithIceOptions.*
+DeserializeSessionDescriptionWithUfragPwd.*
+DeserializeSessionDescriptionWithRecvOnlyContent.*
+DeserializeSessionDescriptionWithSendOnlyContent.*
+DeserializeSessionDescriptionWithInactiveContent.*
+DeserializeSessionDescriptionWithRejectedAudio.*
+DeserializeSessionDescriptionWithRejectedVideo.*
+DeserializeSessionDescriptionWithRejectedAudioVideo.*
+DeserializeSessionDescriptionWithoutMsid.*
+DeserializeCandidate.*
+DeserializeRawCandidateAttribute.*
+DeserializeSdpWithRtpDataChannels.*
+DeserializeSdpWithSctpDataChannels.*
+DeserializeSdpWithRtpDataChannelsAndBandwidth.*
+DeserializeSessionDescriptionWithSessionLevelExtmap.*
+DeserializeSessionDescriptionWithMediaLevelExtmap.*
+DeserializeSessionDescriptionWithInvalidExtmap.*
+DeserializeCandidateWithDifferentTransport.*
+DeserializeCandidateOldFormat.*
+DeserializeBrokenSdp.*
+DeserializeSdpWithReorderedPltypes.*
+DeserializeSerializeCodecParams.*
+DeserializeSerializeRtcpFb.*
+DeserializeSerializeRtcpFbWildcard.*
+DeserializeVideoFmtp.*
+SerializeVideoFmtp.*
+DeserializeSdpWithIceLite.*
+RoundTripSdpWithSctpDataChannelsWithCandidates.*
+SerializeDtlsSetupAttribute.*
+DeserializeDtlsSetupAttribute.*
+WebRtcSessionTest..*
+TestInitialize.*
+TestInitializeWithDtls.*
+TestDefaultSetSecurePolicy.*
+TestSessionCandidates.*
+TestSessionCandidatesWithRtcpMux.*
+TestSessionCandidatesWithBundleRtcpMux.*
+TestMultihomeCandidates.*
+TestStunError.*
+TestCreateOfferReceiveAnswer.*
+TestReceiveOfferCreateAnswer.*
+SetNonCryptoOffer.*
+SetLocalNonCryptoAnswer.*
+SetRemoteNonCryptoAnswer.*
+CreateSetDtlsOffer.*
+ReceiveDtlsOfferCreateAnswer.*
+ReceiveNoDtlsOfferCreateAnswer.*
+TestSetLocalOfferTwice.*
+TestSetRemoteOfferTwice.*
+TestSetLocalAndRemoteOffer.*
+TestSetRemoteAndLocalOffer.*
+TestSetLocalPrAnswer.*
+TestSetRemotePrAnswer.*
+TestSetLocalAnswerWithoutOffer.*
+TestSetRemoteAnswerWithoutOffer.*
+TestAddRemoteCandidate.*
+TestRemoteCandidatesAddedToSessionDescription.*
+TestLocalCandidatesAddedToSessionDescription.*
+TestSetRemoteSessionDescriptionWithCandidates.*
+TestSetLocalAndRemoteDescriptionWithCandidates.*
+TestChannelCreationsWithContentNames.*
+CreateOfferWithoutConstraintsOrStreams.*
+CreateOfferWithoutConstraints.*
+CreateOfferWithConstraintsWithoutStreams.*
+CreateAudioOnlyOfferWithConstraints.*
+CreateOfferWithConstraints.*
+CreateAnswerWithoutAnOffer.*
+CreateAnswerWithoutConstraintsOrStreams.*
+CreateAudioAnswerWithoutConstraintsOrStreams.*
+CreateAnswerWithoutConstraints.*
+CreateAnswerWithConstraintsWithoutStreams.*
+CreateAnswerWithConstraints.*
+CreateOfferWithoutCNCodecs.*
+CreateAnswerWithoutCNCodecs.*
+TestAVOfferWithAudioOnlyAnswer.*
+TestAVOfferWithVideoOnlyAnswer.*
+VerifyCryptoParamsInSDP.*
+VerifyNoCryptoParamsInSDP.*
+VerifyAnswerFromNonCryptoOffer.*
+VerifyAnswerFromCryptoOffer.*
+VerifyBundleFlagInPA.*
+TestDisabledBundleInAnswer.*
+TestDisabledRtcpMuxWithBundleEnabled.*
+SetAudioPlayout.*
+SetAudioSend.*
+SetVideoPlayout.*
+SetVideoSend.*
+CanNotInsertDtmf.*
+CanInsertDtmf.*
+InsertDtmf.*
+TestInitiatorFlagAsOriginator.*
+TestInitiatorFlagAsReceiver.*
+TestInitiatorGIceInAnswer.*
+TestInitiatorIceInAnswer.*
+TestReceiverGIceInOffer.*
+TestReceiverIceInOffer.*
+TestIceOfferGIceOnlyAnswer.*
+TestIncorrectMLinesInRemoteAnswer.*
+TestIncorrectMLinesInLocalAnswer.*
+TestIceStartAfterSetLocalDescriptionOnly.*
+TestCryptoAfterSetLocalDescription.*
+TestCryptoAfterSetLocalDescriptionWithDisabled.*
+TestCreateAnswerWithNewUfragAndPassword.*
+TestCreateAnswerWithOldUfragAndPassword.*
+TestSessionContentError.*
+TestIceStatesBasic.*
+TestNoStateTransitionPendingError.*
+TestRtpDataChannel.*
+TestRtpDataChannelConstraintTakesPrecedence.*
+DISABLED_TestCreateOfferWithSctpEnabledWithoutStreams.*
+TestSctpDataChannelWithoutDtls.*
+TestSctpDataChannelWithDtls.*
+TestCreateOfferBeforeIdentityRequestReturnSuccess.*
+TestCreateAnswerBeforeIdentityRequestReturnSuccess.*
+TestCreateOfferAfterIdentityRequestReturnSuccess.*
+TestCreateOfferAfterIdentityRequestReturnFailure.*
+TestMultipleCreateOfferBeforeIdentityRequestReturnSuccess.*
+TestMultipleCreateOfferBeforeIdentityRequestReturnFailure.*
+TestMultipleCreateAnswerBeforeIdentityRequestReturnSuccess.*
+TestMultipleCreateAnswerBeforeIdentityRequestReturnFailure.*
diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_unittest.gtest-tsan.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_unittest.gtest-tsan.txt
index 164aff6..fb13288 100644
--- a/tools/valgrind-webrtc/gtest_exclude/libjingle_unittest.gtest-tsan.txt
+++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_unittest.gtest-tsan.txt
@@ -2,3 +2,192 @@
CpuMonitorTest.TestCpuMonitor
PhysicalSocketTest.TestUdpReadyToSendIPv4
ThreadTest.Release
+# The following lines disables all tests on tsan since it crashes on shutdown.
+AsyncHttpRequestTest.*
+AsyncHttpRequestTest.*
+FixedSizeLockFreeQueueTest.*
+FixedSizeLockFreeQueueTest.*
+AutoDetectProxyTest.*
+AutoDetectProxyTest.*
+BandwidthSmootherTest.*
+BandwidthSmootherTest.*
+Base64.*
+Base64.*
+BasicTypesTest.*
+BasicTypesTest.*
+BindTest.*
+BindTest.*
+BufferTest.*
+BufferTest.*
+ByteBufferTest.*
+ByteBufferTest.*
+ByteOrderTest.*
+ByteOrderTest.*
+CpuMonitorTest.*
+CpuMonitorTest.*
+Crc32Test.*
+Crc32Test.*
+EventTest.*
+EventTest.*
+FileLockTest.*
+FileLockTest.*
+FilesystemTest.*
+FilesystemTest.*
+RandomTest.*
+RandomTest.*
+HttpBaseTest.*
+HttpBaseTest.*
+Url.*
+Url.*
+HttpResponseData.*
+HttpResponseData.*
+HttpServer.*
+HttpServer.*
+IPAddressTest.*
+IPAddressTest.*
+LogTest.*
+LogTest.*
+Md5DigestTest.*
+Md5DigestTest.*
+MessageDigestTest.*
+MessageDigestTest.*
+MessageQueueTest.*
+MessageQueueTest.*
+MessageQueueManager.*
+MessageQueueManager.*
+MultipartTest.*
+MultipartTest.*
+NatTest.*
+NatTest.*
+NetworkTest.*
+NetworkTest.*
+NullSocketServerTest.*
+NullSocketServerTest.*
+OptionsFile.*
+OptionsFile.*
+Pathname.*
+Pathname.*
+PhysicalSocketTest.*
+PhysicalSocketTest.*
+PosixSignalDeliveryTest.*
+PosixSignalDeliveryTest.*
+ProfilerTest.*
+ProfilerTest.*
+ProxyTest.*
+ProxyTest.*
+RateLimiterTest.*
+RateLimiterTest.*
+RateTrackerTest.*
+RateTrackerTest.*
+ReferenceCountedSingletonFactory.*
+ReferenceCountedSingletonFactory.*
+RollingAccumulatorTest.*
+RollingAccumulatorTest.*
+Sha1DigestTest.*
+Sha1DigestTest.*
+SharedExclusiveLockTest.*
+SharedExclusiveLockTest.*
+SignalThreadTest.*
+SignalThreadTest.*
+SigslotDefault.*
+SigslotDefault.*
+SigslotSTSlotTest.*
+SigslotSTSlotTest.*
+SigslotMTSlotTest.*
+SigslotMTSlotTest.*
+SigslotMTLockTest.*
+SigslotMTLockTest.*
+DestructionOrder.*
+DestructionOrder.*
+SocketAddressTest.*
+SocketAddressTest.*
+StreamSegment.*
+StreamSegment.*
+FifoBufferTest.*
+FifoBufferTest.*
+AsyncWriteTest.*
+AsyncWriteTest.*
+Utf8EncodeTest.*
+Utf8EncodeTest.*
+HexEncodeTest.*
+HexEncodeTest.*
+TokenizeTest.*
+TokenizeTest.*
+SplitTest.*
+SplitTest.*
+BoolTest.*
+BoolTest.*
+string_matchTest.*
+string_matchTest.*
+string_trim_Test.*
+string_trim_Test.*
+string_startsTest.*
+string_startsTest.*
+string_endsTest.*
+string_endsTest.*
+start_task_test.*
+start_task_test.*
+unstarted_task_test.*
+unstarted_task_test.*
+TestClientTest.*
+TestClientTest.*
+ThreadTest.*
+ThreadTest.*
+TimeTest.*
+TimeTest.*
+Urlencode.*
+Urlencode.*
+Urldecode.*
+Urldecode.*
+VersionParsing.*
+VersionParsing.*
+VirtualSocketServerTest.*
+VirtualSocketServerTest.*
+QNameTest.*
+QNameTest.*
+XmlBuilderTest.*
+XmlBuilderTest.*
+XmlElementTest.*
+XmlElementTest.*
+XmlnsStackTest.*
+XmlnsStackTest.*
+XmlParserTest.*
+XmlParserTest.*
+XmlPrinterTest.*
+XmlPrinterTest.*
+HangoutPubSubClientTest.*
+HangoutPubSubClientTest.*
+JidTest.*
+JidTest.*
+MucRoomConfigTaskTest.*
+MucRoomConfigTaskTest.*
+MucRoomDiscoveryTaskTest.*
+MucRoomDiscoveryTaskTest.*
+MucRoomLookupTaskTest.*
+MucRoomLookupTaskTest.*
+MucRoomUniqueHangoutIdTaskTest.*
+MucRoomUniqueHangoutIdTaskTest.*
+PingTaskTest.*
+PingTaskTest.*
+PubSubClientTest.*
+PubSubClientTest.*
+PubSubTasksTest.*
+PubSubTasksTest.*
+XmppEngineTest.*
+XmppEngineTest.*
+XmppLoginTaskTest.*
+XmppLoginTaskTest.*
+XmppStanzaParserTest.*
+XmppStanzaParserTest.*
+LateBindingSymbolTable.*
+LateBindingSymbolTable.*
+LinuxFdWalk.*
+LinuxFdWalk.*
+SSLIdentityTest.*
+SSLIdentityTest.*
+SSLStreamAdapterTestTLS.*
+SSLStreamAdapterTestTLS.*
+SSLStreamAdapterTestDTLS.*
+SSLStreamAdapterTestDTLS.*
+SSLStreamAdapterTestDTLSFromPEMStrings.*
+SSLStreamAdapterTestDTLSFromPEMStrings.*
