| commit | de1590919f4aa01c7b70474c9cde733faef87596 | [log] [tgz] |
|---|---|---|
| author | perkj <perkj@webrtc.org> | Tue May 02 13:14:59 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Tue May 02 13:14:59 2017 |
| tree | a9fa196efd5406c13466e62aa4ada31e165685e0 | |
| parent | d71ebd70f6c40a37559a7ee2930002a804ad3f13 [diff] |
Revert of Relanding: Fixing crash that can occur if signal is modified while firing. (patchset #4 id:60001 of https://codereview.webrtc.org/2846593005/ ) Reason for revert: Breaks XmppConnectionTest in Chrome. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/65096 Original issue's description: > Relanding: Fixing crash that can occur if signal is modified while firing. > > The crash occurs if a slot causes the very next slot in iteration order > to be disconnected. > > Relanding after fixing a race condition that this CL revealed. Previously > the race resulted in an invalidated iterator, but now it will result in the > iterator being modified, so TSan catches it. > > BUG=webrtc:7527 > > Review-Url: https://codereview.webrtc.org/2846593005 > Cr-Original-Commit-Position: refs/heads/master@{#17943} > Committed: https://chromium.googlesource.com/external/webrtc/+/961c2adf1ea25bcc40ad64cae1ac2ea258e26de2 > Review-Url: https://codereview.webrtc.org/2846593005 > Cr-Commit-Position: refs/heads/master@{#17965} > Committed: https://chromium.googlesource.com/external/webrtc/+/fc1af0155718d029a97fddfd64422e9e6e509809 TBR=pthatcher@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7527 Review-Url: https://codereview.webrtc.org/2859443002 Cr-Commit-Position: refs/heads/master@{#17975}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.