commit | e1c3c01a9087e85b3581832da09ebea6c718e5d8 | [log] [tgz] |
---|---|---|
author | Per Kjellander <perkj@webrtc.org> | Thu May 17 12:11:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 17 12:11:22 2018 |
tree | 40b8febbd38ecf2f1b75d185bd4482fcd1a525a4 | |
parent | 739b8169ef7d8e21d2c9fde42096c8f9cfeabe24 [diff] |
Revert "[desktopCapture] Unify the position info in DIP coordinates on Mac." This reverts commit 89653d5db46419d2a80898635cb27fed64898db2. Reason for revert: Tentatively revert since I believe this break remoting unittests on Asan/Tsan https://chromium-review.googlesource.com/c/chromium/src/+/1063330 https://chromium-swarm.appspot.com/task?id=3d8692bedcc85c10&refresh=10&show_raw=1 Original change's description: > [desktopCapture] Unify the position info in DIP coordinates on Mac. > > On OSX, the logical(DIP) and physical coordinates are used mixingly. > For example, the captured image has its size in physical pixels(2x) and > location in logical(DIP) pixels. Same to the cursor position. This > causes trouble when we check the relative position of image and cursor > when there are multiple monitors with different DIP setting connected. > > This cl proposed a solution to use DIP pixel for any location info, > i.e. top-left of a frame and cursor position. Also propose a method to > get the current scale factor of a window across multiple monitors. And > save the current scale factor in DPI of the capture frame. > Then we can check relative position of cursor and frame correctly > in DIP pixel and compose them in physical pixel. > > Bug: webrtc:9178 > Change-Id: I3c076aeac2d6f2c1f63d000d7fff03500aa375ac > Reviewed-on: https://webrtc-review.googlesource.com/71621 > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Reviewed-by: Zijie He <zijiehe@chromium.org> > Commit-Queue: Brave Yao <braveyao@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23263} TBR=zijiehe@chromium.org,jamiewalch@chromium.org,perkj@webrtc.org,braveyao@webrtc.org Change-Id: Ica02365925623e21b256d20a21b5625e7ed6f49b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9178 Reviewed-on: https://webrtc-review.googlesource.com/77461 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23280}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.