commit e252a12070e5b225cc8e85e1c556df43e79660f3
author Maksim Ivanov <emaxx@chromium.org> Tue Dec 14 01:37:22 2021
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 14 21:16:18 2021
tree b99f8754fe07a63f74b0e0ed2e0f38aa2a36aeb4
parent 5279e5278b0570784c0c11bea64b763ca52ad454

Fix use-after-move in RTCErrorOr

Fix a use-after-move issue in RTCErrorOr, as found by clang-tidy:

  api/rtc_error.h:247:
  'error' used after it was moved

Bug: chromium:1122844
Change-Id: I9e826023618067ba37c2567b5e194c46db1dbd23
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241200
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35535}

api/rtc_error.h

diff --git a/api/rtc_error.h b/api/rtc_error.h
index 1376793..42ceed1 100644
--- a/api/rtc_error.h
+++ b/api/rtc_error.h
@@ -244,7 +244,7 @@
   //
   // REQUIRES: !error.ok(). This requirement is DCHECKed.
   RTCErrorOr(RTCError&& error) : error_(std::move(error)) {  // NOLINT
-    RTC_DCHECK(!error.ok());
+    RTC_DCHECK(!error_.ok());
   }
 
   // Constructs a new RTCErrorOr with the given value. After calling this