| commit | e864dec2e98bb0786c015aabc712cf978b5e3634 | [log] [tgz] |
|---|---|---|
| author | Markus Handell <handellm@webrtc.org> | Wed Aug 07 14:11:18 2024 |
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 08 11:02:50 2024 |
| tree | d91bae1aaaab47f98cdc1a2890d65a6c8a141cdf | |
| parent | 07e83f244b611b602e2484a4d9a86c6febda0b42 [diff] |
VSyncEncodeAdapterMode: avoid UAF. This CL fixes a problem where VSEAM's `queue_` was dereferenced post destruction. A sequence triggering it is: 0. FrameCadenceAdapter (FCA) is configured with Metronome with >= 34 ms tick delay. 1. A frame is queued for processing on worker queue. 2. The FCA is destroyed. The contained VSyncEncodeAdapterMode instance is scheduled for deletion on worker queue. 3. Encode queue is destroyed. 4. Worker queue is executed, which runs a task that dereferences `queue_`. Bug: chromium:356423094 Change-Id: Iae8dc070304ef5ec0cfb0b4f27bbb7fe86e7def7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358660 Commit-Queue: Markus Handell <handellm@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42745}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.