commit edab3011fa79803ed4e93836d924d266cd4df013
author Bjorn Terelius <terelius@webrtc.org> Wed Jan 31 16:23:40 2018
committer Commit Bot <commit-bot@chromium.org> Thu Feb 01 19:47:41 2018
tree 10569f5e8fe1a70bcde91c2054c7fd68b9f08b09
parent 9a5c6f8f3fc8adefc69809c712e0466586f2a2d8

Remove webrtc::test::InitFieldTrialsFromString(const std::string&).

This is done to solve a problem where a string literal is implicitly cast
to a temporary std::string when calling webrtc::test::InitFieldTrialsFromString
which passes a pointer to the internal representation to
webrtc::field_trial::InitFieldTrialFromString(char*). This pointer is
stored for later use, but the temporary std::string is destroyed as soon
as the function returns.

Using webrtc::field_trial::InitFieldTrialFromString(char*) instead,
avoids the implicit casts (but the caller still needs to ensure that
the char* outlives the program). The validation previously done by
webrtc::test::InitFieldTrialsFromString can now be done by manually
calling webrtc::test::ValidateFieldTrialsStringOrDie(const std::string&).

Add system_wrappers:field_trial_default as a direct dependency to
various targets to allow including the field_trials_default.h header.

Bug: webrtc:8812
Change-Id: Ib5a641ea255b1c16a8f7f35e1fe67f6c38a61da6
Reviewed-on: https://webrtc-review.googlesource.com/46141
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21856}