Rename elad.alon to eladalon, to avoid confusion between repositories.
BUG=None
NOTRY=true
Review-Url: https://codereview.webrtc.org/2899303002
Cr-Commit-Position: refs/heads/master@{#18264}
diff --git a/webrtc/audio/audio_send_stream.cc b/webrtc/audio/audio_send_stream.cc
index 1a5f28e..f89da98 100644
--- a/webrtc/audio/audio_send_stream.cc
+++ b/webrtc/audio/audio_send_stream.cc
@@ -36,7 +36,7 @@
namespace webrtc {
namespace internal {
-// TODO(elad.alon): Subsequent CL will make these values experiment-dependent.
+// TODO(eladalon): Subsequent CL will make these values experiment-dependent.
constexpr size_t kPacketLossTrackerMaxWindowSizeMs = 15000;
constexpr size_t kPacketLossRateMinNumAckedPackets = 50;
constexpr size_t kRecoverablePacketLossRateMinNumAckedPairs = 40;
@@ -340,7 +340,7 @@
// Only packets that belong to this stream are of interest.
if (ssrc == config_.rtp.ssrc) {
rtc::CritScope lock(&packet_loss_tracker_cs_);
- // TODO(elad.alon): This function call could potentially reset the window,
+ // TODO(eladalon): This function call could potentially reset the window,
// setting both PLR and RPLR to unknown. Consider (during upcoming
// refactoring) passing an indication of such an event.
packet_loss_tracker_.OnPacketAdded(seq_num, rtc::TimeMillis());
@@ -349,7 +349,7 @@
void AudioSendStream::OnPacketFeedbackVector(
const std::vector<PacketFeedback>& packet_feedback_vector) {
- // TODO(elad.alon): This fails in UT; fix and uncomment.
+ // TODO(eladalon): This fails in UT; fix and uncomment.
// See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
// RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
rtc::Optional<float> plr;
@@ -360,7 +360,7 @@
plr = packet_loss_tracker_.GetPacketLossRate();
rplr = packet_loss_tracker_.GetRecoverablePacketLossRate();
}
- // TODO(elad.alon): If R/PLR go back to unknown, no indication is given that
+ // TODO(eladalon): If R/PLR go back to unknown, no indication is given that
// the previously sent value is no longer relevant. This will be taken care
// of with some refactoring which is now being done.
if (plr) {
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h b/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h
index 81abe24..844e38b 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h
@@ -76,7 +76,7 @@
// Scoring point is a subset of NetworkMetrics that is used for comparing the
// significance of controllers.
struct ScoringPoint {
- // TODO(elad.alon): Do we want to experiment with RPLR-based scoring?
+ // TODO(eladalon): Do we want to experiment with RPLR-based scoring?
ScoringPoint(int uplink_bandwidth_bps, float uplink_packet_loss_fraction);
// Calculate the normalized [0,1] distance between two scoring points.
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/util/threshold_curve.h b/webrtc/modules/audio_coding/audio_network_adaptor/util/threshold_curve.h
index 2af4a93..87ffc02 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/util/threshold_curve.h
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/util/threshold_curve.h
@@ -49,7 +49,7 @@
b(GetPoint(left, right, false)),
slope(b.x - a.x == 0.0f ? 0.0f : (b.y - a.y) / (b.x - a.x)),
offset(a.y - slope * a.x) {
- // TODO(elad.alon): We might want to introduce some numerical validations.
+ // TODO(eladalon): We might want to introduce some numerical validations.
}
ThresholdCurve(float a_x, float a_y, float b_x, float b_y)
diff --git a/webrtc/voice_engine/channel_proxy.cc b/webrtc/voice_engine/channel_proxy.cc
index 25978c7..46bcef9 100644
--- a/webrtc/voice_engine/channel_proxy.cc
+++ b/webrtc/voice_engine/channel_proxy.cc
@@ -308,7 +308,7 @@
}
void ChannelProxy::OnTwccBasedUplinkPacketLossRate(float packet_loss_rate) {
- // TODO(elad.alon): This fails in UT; fix and uncomment.
+ // TODO(eladalon): This fails in UT; fix and uncomment.
// See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
// RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
channel()->OnTwccBasedUplinkPacketLossRate(packet_loss_rate);
@@ -316,7 +316,7 @@
void ChannelProxy::OnRecoverableUplinkPacketLossRate(
float recoverable_packet_loss_rate) {
- // TODO(elad.alon): This fails in UT; fix and uncomment.
+ // TODO(eladalon): This fails in UT; fix and uncomment.
// See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
// RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
channel()->OnRecoverableUplinkPacketLossRate(recoverable_packet_loss_rate);
diff --git a/webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc b/webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc
index 9f7d578..f019203 100644
--- a/webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc
+++ b/webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc
@@ -96,7 +96,7 @@
const TransportFeedbackPacketLossTracker& tracker,
rtc::Optional<float> expected_plr,
rtc::Optional<float> expected_rplr) {
- // TODO(elad.alon): Comparing the rtc::Optional<float> directly would have
+ // TODO(eladalon): Comparing the rtc::Optional<float> directly would have
// given concise code, but less readable error messages. If we modify
// the way rtc::Optional is printed, we can get rid of this.
rtc::Optional<float> plr = tracker.GetPacketLossRate();
