commit ee58849235967f50ee66dce87595eea3287b3569
author Palak Agarwal <agpalak@google.com> Fri Jun 09 09:28:40 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 12 13:41:27 2023
tree 020a443539c45c8a963d19a3b34a305e5bc2a27c
parent 47bdcc1e246ee8efaab3d1eddff5ef26d21f2679

Make SetRTPTimestamp pure virtual in TransformableAudioFrameInterface

This can be done now as the function SetRTPTimestamp is now overriden
in blink MockTransformableAudioFrame.

Change-Id: I4fa4cb81d0282fea864818f0f2d9a5ed881a5d30
Bug: webrtc:14709
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/308361
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Palak Agarwal <agpalak@google.com>
Cr-Commit-Position: refs/heads/main@{#40257}

api/frame_transformer_interface.h

diff --git a/api/frame_transformer_interface.h b/api/frame_transformer_interface.h
index bfe3b02..d4b09a4 100644
--- a/api/frame_transformer_interface.h
+++ b/api/frame_transformer_interface.h
@@ -68,11 +68,11 @@
  public:
   virtual ~TransformableAudioFrameInterface() = default;
 
+  virtual void SetRTPTimestamp(uint32_t timestamp) = 0;
   // Exposes the frame header, enabling the interface clients to use the
   // information in the header as needed, for example to compile the list of
   // csrcs.
   virtual const RTPHeader& GetHeader() const = 0;
-  virtual void SetRTPTimestamp(uint32_t timestamp) { RTC_CHECK_NOTREACHED(); }
 
   virtual rtc::ArrayView<const uint32_t> GetContributingSources() const = 0;
 };

api/test/mock_transformable_audio_frame.h

diff --git a/api/test/mock_transformable_audio_frame.h b/api/test/mock_transformable_audio_frame.h
index c8d24f0..912488a 100644
--- a/api/test/mock_transformable_audio_frame.h
+++ b/api/test/mock_transformable_audio_frame.h
@@ -20,11 +20,11 @@
  public:
   MOCK_METHOD(rtc::ArrayView<const uint8_t>, GetData, (), (const, override));
   MOCK_METHOD(void, SetData, (rtc::ArrayView<const uint8_t>), (override));
+  MOCK_METHOD(void, SetRTPTimestamp, (uint32_t), (override));
   MOCK_METHOD(uint8_t, GetPayloadType, (), (const, override));
   MOCK_METHOD(uint32_t, GetSsrc, (), (const, override));
   MOCK_METHOD(uint32_t, GetTimestamp, (), (const, override));
   MOCK_METHOD(RTPHeader&, GetHeader, (), (const override));
-  MOCK_METHOD(void, SetRTPTimestamp, (uint32_t), (override));
   MOCK_METHOD(rtc::ArrayView<const uint32_t>,
               GetContributingSources,
               (),