Adopt absl::string_view in modules/audio_processing/ Bug: webrtc:13579 Change-Id: Idb05a64cfd16aed68d40cd427a6b516caa5e2077 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269387 Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Commit-Queue: Ali Tofigh <alito@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37800}
diff --git a/modules/audio_processing/test/debug_dump_test.cc b/modules/audio_processing/test/debug_dump_test.cc index b735160..d69d3a4 100644 --- a/modules/audio_processing/test/debug_dump_test.cc +++ b/modules/audio_processing/test/debug_dump_test.cc
@@ -14,6 +14,7 @@ #include <string> #include <vector> +#include "absl/strings/string_view.h" #include "api/audio/echo_canceller3_factory.h" #include "modules/audio_coding/neteq/tools/resample_input_audio_file.h" #include "modules/audio_processing/aec_dump/aec_dump_factory.h" @@ -41,13 +42,13 @@ class DebugDumpGenerator { public: - DebugDumpGenerator(const std::string& input_file_name, + DebugDumpGenerator(absl::string_view input_file_name, int input_rate_hz, int input_channels, - const std::string& reverse_file_name, + absl::string_view reverse_file_name, int reverse_rate_hz, int reverse_channels, - const std::string& dump_file_name, + absl::string_view dump_file_name, bool enable_pre_amplifier); // Constructor that uses default input files. @@ -115,13 +116,13 @@ const std::string dump_file_name_; }; -DebugDumpGenerator::DebugDumpGenerator(const std::string& input_file_name, +DebugDumpGenerator::DebugDumpGenerator(absl::string_view input_file_name, int input_rate_hz, int input_channels, - const std::string& reverse_file_name, + absl::string_view reverse_file_name, int reverse_rate_hz, int reverse_channels, - const std::string& dump_file_name, + absl::string_view dump_file_name, bool enable_pre_amplifier) : input_config_(input_rate_hz, input_channels), reverse_config_(reverse_rate_hz, reverse_channels), @@ -254,13 +255,13 @@ // VerifyDebugDump replays a debug dump using APM and verifies that the result // is bit-exact-identical to the output channel in the dump. This is only // guaranteed if the debug dump is started on the first frame. - void VerifyDebugDump(const std::string& in_filename); + void VerifyDebugDump(absl::string_view in_filename); private: DebugDumpReplayer debug_dump_replayer_; }; -void DebugDumpTest::VerifyDebugDump(const std::string& in_filename) { +void DebugDumpTest::VerifyDebugDump(absl::string_view in_filename) { ASSERT_TRUE(debug_dump_replayer_.SetDumpFile(in_filename)); while (const absl::optional<audioproc::Event> event =