commit f640b87f1c64b9b13ca5058486b0626e731e94bd
author Bjorn Terelius <terelius@webrtc.org> Wed Jul 24 13:46:39 2019
committer Commit Bot <commit-bot@chromium.org> Wed Jul 24 14:23:18 2019
tree 3c51f2fe74db33778b81b148db70f4aad3615fc7
parent 9973933d2e606d64fcdc753acb9ba3afd6e30569

Populate y-axis categorical labels in event log visualizer.

Bug: webrtc:10623
Change-Id: Ica2f6485e44ffa6331e88d7980c294d93bed1539
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145410
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28665}

rtc_tools/event_log_visualizer/analyzer.cc

diff --git a/rtc_tools/event_log_visualizer/analyzer.cc b/rtc_tools/event_log_visualizer/analyzer.cc
index 11e33f29..6e2bf26 100644
--- a/rtc_tools/event_log_visualizer/analyzer.cc
+++ b/rtc_tools/event_log_visualizer/analyzer.cc
@@ -567,6 +567,14 @@
                  "Time (s)", kLeftMargin, kRightMargin);
   plot->SetSuggestedYAxis(0, 1, "RTCP type", kBottomMargin, kTopMargin);
   plot->SetTitle(GetDirectionAsString(direction) + " RTCP packets");
+  plot->SetYAxisTickLabels({{1, "TWCC"},
+                            {2, "RR"},
+                            {3, "SR"},
+                            {4, "XR"},
+                            {5, "NACK"},
+                            {6, "REMB"},
+                            {7, "FIR"},
+                            {8, "PLI"}});
 }
 
 template <typename IterableType>
@@ -2116,9 +2124,15 @@
 
   plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(),
                  "Time (s)", kLeftMargin, kRightMargin);
-  plot->SetSuggestedYAxis(0, 3, "Numeric Config Type", kBottomMargin,
-                          kTopMargin);
+  plot->SetSuggestedYAxis(0, 3, "Config Type", kBottomMargin, kTopMargin);
   plot->SetTitle("[IceEventLog] ICE candidate pair configs");
+  plot->SetYAxisTickLabels(
+      {{static_cast<float>(IceCandidatePairConfigType::kAdded), "ADDED"},
+       {static_cast<float>(IceCandidatePairConfigType::kUpdated), "UPDATED"},
+       {static_cast<float>(IceCandidatePairConfigType::kDestroyed),
+        "DESTROYED"},
+       {static_cast<float>(IceCandidatePairConfigType::kSelected),
+        "SELECTED"}});
 }
 
 std::string EventLogAnalyzer::GetCandidatePairLogDescriptionFromId(
@@ -2142,6 +2156,8 @@
 }
 
 void EventLogAnalyzer::CreateIceConnectivityCheckGraph(Plot* plot) {
+  constexpr int kEventTypeOffset =
+      static_cast<int>(IceCandidatePairConfigType::kNumValues);
   std::map<uint32_t, TimeSeries> checks_by_cp_id;
   for (const auto& event : parsed_log_.ice_candidate_pair_events()) {
     if (checks_by_cp_id.find(event.candidate_pair_id) ==
@@ -2152,9 +2168,7 @@
           LineStyle::kNone, PointStyle::kHighlight);
     }
     float x = config_.GetCallTimeSec(event.log_time_us());
-    constexpr int kIceCandidatePairEventTypeOffset =
-        static_cast<int>(IceCandidatePairConfigType::kNumValues);
-    float y = static_cast<float>(event.type) + kIceCandidatePairEventTypeOffset;
+    float y = static_cast<float>(event.type) + kEventTypeOffset;
     checks_by_cp_id[event.candidate_pair_id].points.emplace_back(x, y);
   }
 
@@ -2165,9 +2179,23 @@
 
   plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(),
                  "Time (s)", kLeftMargin, kRightMargin);
-  plot->SetSuggestedYAxis(0, 4, "Numeric Connectivity State", kBottomMargin,
+  plot->SetSuggestedYAxis(0, 4, "Connectivity State", kBottomMargin,
                           kTopMargin);
   plot->SetTitle("[IceEventLog] ICE connectivity checks");
+
+  plot->SetYAxisTickLabels(
+      {{static_cast<float>(IceCandidatePairEventType::kCheckSent) +
+            kEventTypeOffset,
+        "CHECK SENT"},
+       {static_cast<float>(IceCandidatePairEventType::kCheckReceived) +
+            kEventTypeOffset,
+        "CHECK RECEIVED"},
+       {static_cast<float>(IceCandidatePairEventType::kCheckResponseSent) +
+            kEventTypeOffset,
+        "RESPONSE SENT"},
+       {static_cast<float>(IceCandidatePairEventType::kCheckResponseReceived) +
+            kEventTypeOffset,
+        "RESPONSE RECEIVED"}});
 }
 
 void EventLogAnalyzer::CreateDtlsTransportStateGraph(Plot* plot) {
@@ -2182,8 +2210,14 @@
   plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(),
                  "Time (s)", kLeftMargin, kRightMargin);
   plot->SetSuggestedYAxis(0, static_cast<float>(DtlsTransportState::kNumValues),
-                          "Numeric Transport State", kBottomMargin, kTopMargin);
+                          "Transport State", kBottomMargin, kTopMargin);
   plot->SetTitle("DTLS Transport State");
+  plot->SetYAxisTickLabels(
+      {{static_cast<float>(DtlsTransportState::kNew), "NEW"},
+       {static_cast<float>(DtlsTransportState::kConnecting), "CONNECTING"},
+       {static_cast<float>(DtlsTransportState::kConnected), "CONNECTED"},
+       {static_cast<float>(DtlsTransportState::kClosed), "CLOSED"},
+       {static_cast<float>(DtlsTransportState::kFailed), "FAILED"}});
 }
 
 void EventLogAnalyzer::CreateDtlsWritableStateGraph(Plot* plot) {