commit | 92fa17660f0036d416f3eecb0f9849a141963c6f | [log] [tgz] |
---|---|---|
author | Joe Downing <joedow@google.com> | Thu Oct 15 17:19:26 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Oct 15 19:09:36 2020 |
tree | 76a1b6e5941677f17c5401b728cc0a7ae2d66c0f | |
parent | a94348440be58081756e037c3b8b7555e87721df [diff] |
Fixing the error logging in desktop_capture for Windows The desktop_capture code logs failed HRESULTs in several places, the problem is that it tries to use a wchar* (when a char* is required) for the error message and doesn't display the HRESULT in hex. This makes the error logging less useful than it could be. Example failure: error 08406B28, with code -2005270488 In this CL, I add a simple utility function to convert a _com_error object to a std::string whic can be logged. With this change the output looks like this (linebreak added for CL description): Failed to capture frame: HRESULT: 0x887A0026, Message: 'The keyed mutex was abandoned.' I also adjusted the formatting of a few logging statements to be more consistent (adding '<<' operators mostly). Bug: webrtc:12051 Change-Id: I3e88ff6f2ff079fbe210626e1e89b2b053a742a9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/188522 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#32417}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.