Fix presubmit check for webrtc/base.
Show a warning only when there's something to warn about.
TBR=kjellander@webrtc.org
NOTRY=True
BUG=webrtc:7634
Review-Url: https://codereview.webrtc.org/2974093002
Cr-Commit-Position: refs/heads/master@{#18952}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index bcdf427..ca6a70a 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -522,10 +522,12 @@
if 'webrtc/base' in line:
problems.append(' %s: %s' % (f.LocalPath(), line_num))
- return [output_api.PresubmitPromptWarning(
- 'webrtc/base is being moved to webrtc/rtc_base (See '
- 'bugs.webrtc.org/7634). Please refer to webrtc/rtc_base instead in the '
- 'following files:\n' + '\n'.join(problems))]
+ if problems:
+ return [output_api.PresubmitPromptWarning(
+ 'webrtc/base is being moved to webrtc/rtc_base (See '
+ 'bugs.webrtc.org/7634). Please refer to webrtc/rtc_base instead in the '
+ 'following files:\n' + '\n'.join(problems))]
+ return []
def _CommonChecks(input_api, output_api):
