commit | 92ba70c1c575a82b64ae9c99912c0d2955ee3f15 | [log] [tgz] |
---|---|---|
author | Henrik Boström <hbos@webrtc.org> | Tue Apr 27 09:35:07 2021 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 30 08:19:10 2021 |
tree | a36b52b735ae965d044f7235a7a44d77559bf190 | |
parent | 8679ac1d10e2d1ba4a2e091000dc6246745f49f1 [diff] |
[LibvpxVp8Encoder] Allow I420A to be scaled to I420. In Chromium, the I420ABufferInterface implementation uses the default CropAndScale() implementation which converts to I420 in the process. This should be OK, because we do not encode the alpha channel anyway, so having WebRTC scaling ignore the alpha channel might even be a good thing. Unfortunatety, an if statement in the LibvpxVp8Encoder did not consider I420A and I420 to be the same, resulting in dropping perfectly valid frames. This CL fixes that by considering I420A and I420 "compatible" in a comparison helper function. The problem only happens in this encoder, so only this encoder needs to be fixed. TBR=ilnik@chromium.org,eshr@google.com (cherry picked from commit 065ce9cb227a86ca9c5cf1469a5edd9ffd7a662a) Bug: chromium:1203206 Change-Id: Iec434d4ada897c79e09914cac823148fd5b05e57 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/216323 Reviewed-by: Evan Shrubsole <eshr@google.com> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#33845} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/216682 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Markus Handell <handellm@webrtc.org> Cr-Commit-Position: refs/branch-heads/4472@{#9} Cr-Branched-From: 3e0c60ba4ef28a9f26fe991e5eec3150402c7dd3-refs/heads/master@{#33644}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.