commit 065a52a655c7eba91bcf2d067c661b06279ce5a4
author Danil Chapovalov <danilchap@webrtc.org> Mon Jul 09 08:58:54 2018
committer Commit Bot <commit-bot@chromium.org> Wed Jul 11 19:02:51 2018
tree 4febcbfcc7cef003453280766986e2cb8f87ea28
parent 8280a56e15d975598161240658a942d7be224574

Reland "Remove rtc::Optional alias and api:optional target"

This is an reland of 6f5b0f920af08d66e6b77ee4f91ade5797145368
Relanded after speculative revert without any changes.

TBR=ilnik@webrtc.org

Original change's description:
> Remove rtc::Optional alias and api:optional target
>
> Update left-overs where old target still was used.
>
> Bug: webrtc:9078
> Change-Id: I2162c928091fc4ff1dea33a3f03adbe47207d206
> Reviewed-on: https://webrtc-review.googlesource.com/84740
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23913}

Bug: webrtc:9078
Change-Id: Ia33c6438253c6ec49f45d938e8a3607b51c418be
Reviewed-on: https://webrtc-review.googlesource.com/88160
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23941}

api/BUILD.gn

diff --git a/api/BUILD.gn b/api/BUILD.gn
index 4357947..71c2ec3 100644
--- a/api/BUILD.gn
+++ b/api/BUILD.gn
@@ -257,9 +257,9 @@
     "test/simulated_network.h",
   ]
   deps = [
-    ":optional",
     "../rtc_base:criticalsection",
     "../rtc_base:rtc_base",
+    "//third_party/abseil-cpp/absl/types:optional",
   ]
 }
 
@@ -286,18 +286,6 @@
   ]
 }
 
-# TODO(bugs.webrtc.org/9078): Deprecated, replaced by absl/types:optional.
-# Delete after webrtc and downstreams users are updated.
-rtc_source_set("optional") {
-  visibility = [ "*" ]
-  sources = [
-    "optional.h",
-  ]
-  deps = [
-    "//third_party/abseil-cpp/absl/types:optional",
-  ]
-}
-
 rtc_source_set("refcountedbase") {
   visibility = [ "*" ]
   sources = [
@@ -477,10 +465,6 @@
 
     sources = [
       "array_view_unittest.cc",
-
-      # TODO(bugs.webrtc.org/8821): Remove optional_unittests when webrtc starts
-      # running absl unittest on each commit.
-      "optional_unittest.cc",
       "ortc/mediadescription_unittest.cc",
       "ortc/sessiondescription_unittest.cc",
       "rtcerror_unittest.cc",
@@ -496,7 +480,6 @@
       ":array_view",
       ":libjingle_peerconnection_api",
       ":libjingle_peerconnection_test_api",
-      ":optional",
       ":ortc_api",
       "../rtc_base:checks",
       "../rtc_base:rtc_base_approved",