Google Git
Sign in
webrtc / src / / 2d2c888293fe5d1a4204d5026d6d630b47f6044a
commit2d2c888293fe5d1a4204d5026d6d630b47f6044a[log] [tgz]
authorSeth Hampson <shampson@webrtc.org>Wed May 16 23:02:32 2018
committerCommit Bot <commit-bot@chromium.org>Fri May 18 17:40:16 2018
tree1d466e98f36605fa80e176950fc27d1309fe8c23
parentdfce03af6ea34ced4c5038b11b4b5f29a4b310e5 [diff]
Returns RTCError for setting unimplemented RtpParameters.

We have a number of RtpParameters that aren't implemented. If a client
is setting these values it creates unexpected results when the value
doesn't do anything for them. This change incorporates returning the
correct error if the parameter is unimplemented.

It also changes the scale_resolution_down_by and scale_framerate_down_by
RtpEncodingParameters to rtc::Optionals because they aren't implemented.

This change is part of the effort to ship get/setParameters in Chrome.

Bug: webrtc:8772
Change-Id: I9797695e5116e6aeb3c02afddbf460b2a0d7d5ab
Reviewed-on: https://webrtc-review.googlesource.com/75421
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23314}
4 files changed
tree: 1d466e98f36605fa80e176950fc27d1309fe8c23
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. examples/
  9. infra/
  10. logging/
  11. media/
  12. modules/
  13. ortc/
  14. p2p/
  15. pc/
  16. resources/
  17. rtc_base/
  18. rtc_tools/
  19. sdk/
  20. stats/
  21. style-guide/
  22. system_wrappers/
  23. test/
  24. third_party/
  25. tools_webrtc/
  26. video/
  27. .clang-format
  28. .git-blame-ignore-revs
  29. .gitignore
  30. .gn
  31. .vpython
  32. AUTHORS
  33. BUILD.gn
  34. CODE_OF_CONDUCT.md
  35. codereview.settings
  36. common_types.cc
  37. common_types.h
  38. DEPS
  39. LICENSE
  40. license_template.txt
  41. LICENSE_THIRD_PARTY
  42. native-api.md
  43. OWNERS
  44. PATENTS
  45. PRESUBMIT.py
  46. presubmit_test.py
  47. presubmit_test_mocks.py
  48. pylintrc
  49. README.chromium
  50. README.md
  51. style-guide.md
  52. THIRD_PARTY_CHROMIUM_DEPS.json
  53. THIRD_PARTY_WEBRTC_DEPS.json
  54. typedefs.h
  55. WATCHLISTS
  56. webrtc.gni
  57. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info