Reland of Enabling `gn check` on webrtc/test (patchset #1 id:1 of https://codereview.webrtc.org/2920763002/ )
Reason for revert:
Fixing and re-landing.
Original issue's description:
> Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ )
>
> Reason for revert:
> ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here.
> #include "webrtc/base/checks.h"
> ^-------------------
> The target:
> //webrtc/test:fileutils_unittests
> is including a file from the target:
> //webrtc/base:rtc_base_approved
>
> It's usually best to depend directly on the destination target.
> In some cases, the destination target is considered a subcomponent
> of an intermediate target. In this case, the intermediate target
> should depend publicly on the destination to forward the ability
> to include headers.
>
> Dependency chain (there may also be others):
> //webrtc/test:fileutils_unittests -->
> //webrtc/test:fileutils --[private]-->
> //webrtc/base:rtc_base_approved
>
>
> Original issue's description:
> > Enabling `gn check` on webrtc/test
> >
> > BUG=webrtc:6828
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2911203002
> > Cr-Commit-Position: refs/heads/master@{#18372}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2
>
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828
>
> Review-Url: https://codereview.webrtc.org/2920763002
> Cr-Commit-Position: refs/heads/master@{#18375}
> Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8
TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828
Review-Url: https://codereview.webrtc.org/2918793002
Cr-Commit-Position: refs/heads/master@{#18376}
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index bb04e19..0d234cd 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -58,9 +58,14 @@
}
deps = [
+ "..:video_stream_api",
+ "..:webrtc_common",
+ "../base:rtc_base_approved",
+ "../base:rtc_task_queue",
"../common_video",
"../media:rtc_media_base",
"../modules/video_capture:video_capture_module",
+ "../system_wrappers",
]
}
@@ -82,6 +87,7 @@
deps = [
"..:webrtc_common",
+ "../base:rtc_base_approved",
"../modules/rtp_rtcp",
"//testing/gtest",
]
@@ -165,6 +171,7 @@
]
deps = [
":field_trial",
+ "../base:rtc_base_approved",
"../system_wrappers:metrics_default",
"//testing/gmock",
"//testing/gtest",
@@ -188,6 +195,9 @@
]
deps = [
+ ":test_support",
+ ":video_test_common",
+ "..:webrtc_common",
"../base:rtc_base_approved",
"../common_video",
"../system_wrappers",
@@ -252,7 +262,16 @@
}
rtc_test("test_support_unittests") {
- deps = []
+ deps = [
+ ":fake_audio_device",
+ ":rtp_test_utils",
+ "../api:video_frame_api",
+ "../base:rtc_base_approved",
+ "../call:call_interfaces",
+ "../common_audio",
+ "../modules/rtp_rtcp",
+ "../system_wrappers",
+ ]
sources = [
"fake_audio_device_unittest.cc",
"fake_network_pipe_unittest.cc",
@@ -314,11 +333,16 @@
"testsupport/fileutils.cc",
"testsupport/fileutils.h",
]
+ deps = [
+ "..:webrtc_common",
+ "../base:rtc_base_approved",
+ ]
if (is_ios) {
sources += [ "testsupport/iosfileutils.mm" ]
- deps = [
- "../sdk:objc_common",
- ]
+ deps += [ "../sdk:objc_common" ]
+ }
+ if (is_win) {
+ deps += [ "../base:rtc_base" ]
}
visibility = [ ":*" ]
}
@@ -343,6 +367,8 @@
]
deps = [
":fileutils",
+ ":test_support",
+ "../base:rtc_base_approved",
"//testing/gmock",
"//testing/gtest",
]
@@ -361,9 +387,12 @@
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
+ "..:webrtc_common",
"../api:transport_api",
"../base:rtc_base_approved",
"../call",
+ "../modules/rtp_rtcp",
+ "../system_wrappers",
]
}
@@ -378,8 +407,11 @@
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
+ "..:webrtc_common",
"../base:rtc_base_approved",
+ "../common_audio:common_audio",
"../modules/audio_device:audio_device",
+ "../system_wrappers:system_wrappers",
]
}
@@ -431,15 +463,30 @@
":rtp_test_utils",
":test_support",
":video_test_common",
+ "..:video_stream_api",
"..:webrtc_common",
+ "../api:transport_api",
+ "../api:video_frame_api",
+ "../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
"../api/video_codecs:video_codecs_api",
"../audio",
"../base:rtc_base_approved",
+ "../base:rtc_task_queue",
"../call",
+ "../common_video",
+ "../logging:rtc_event_log_api",
+ "../modules/audio_device:mock_audio_device",
"../modules/audio_mixer:audio_mixer_impl",
"../modules/audio_processing",
+ "../modules/rtp_rtcp",
+ "../modules/rtp_rtcp:mock_rtp_rtcp",
+ "../modules/video_coding:webrtc_h264",
+ "../modules/video_coding:webrtc_vp8",
+ "../modules/video_coding:webrtc_vp9",
+ "../system_wrappers",
"../video",
+ "../voice_engine",
"//testing/gmock",
"//testing/gtest",
]
@@ -515,6 +562,9 @@
deps = [
":test_support",
+ "..:webrtc_common",
+ "../base:rtc_base_approved",
+ "../common_video",
"../modules/media_file",
"//testing/gtest",
]
@@ -531,7 +581,10 @@
]
deps = [
+ ":test_support",
"../api/audio_codecs:audio_codecs_api",
+ "../api/audio_codecs:builtin_audio_decoder_factory",
+ "../base:rtc_base_approved",
"//testing/gmock",
]
}
