commit 40cb0091a19a93218a813fd06e5c99488f225169
author philipel <philipel@webrtc.org> Wed Apr 05 12:05:12 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 05 15:13:36 2023
tree 4e7312cebbb9c6df94f2b43563c1352726dd09ed
parent 7ceb49c7b82fcb7ffc337f113767da9ba4689249

Unnest VideoEncoderFactoryTemplate in webrtc_video_engine_unittest.cc

Bug: webrtc:13573
Change-Id: I43517b6b7a130704803ff149b8a738ed4713d88a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300361
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39767}

media/engine/webrtc_video_engine_unittest.cc

diff --git a/media/engine/webrtc_video_engine_unittest.cc b/media/engine/webrtc_video_engine_unittest.cc
index 7f77a12..8447c82 100644
--- a/media/engine/webrtc_video_engine_unittest.cc
+++ b/media/engine/webrtc_video_engine_unittest.cc
@@ -130,34 +130,6 @@
 static const char kUnsupportedExtensionName[] =
     "urn:ietf:params:rtp-hdrext:unsupported";
 
-class FuzzyMatchedVideoEncoderFactory : public webrtc::VideoEncoderFactory {
- public:
-  std::vector<webrtc::SdpVideoFormat> GetSupportedFormats() const override {
-    return factory_.GetSupportedFormats();
-  }
-
-  std::unique_ptr<webrtc::VideoEncoder> CreateVideoEncoder(
-      const webrtc::SdpVideoFormat& format) override {
-    absl::optional<webrtc::SdpVideoFormat> matched_format =
-        webrtc::FuzzyMatchSdpVideoFormat(factory_.GetSupportedFormats(),
-                                         format);
-    return factory_.CreateVideoEncoder(matched_format.value_or(format));
-  }
-
-  CodecSupport QueryCodecSupport(
-      const webrtc::SdpVideoFormat& format,
-      absl::optional<std::string> scalability_mode) const override {
-    return factory_.QueryCodecSupport(format, scalability_mode);
-  }
-
- private:
-  webrtc::VideoEncoderFactoryTemplate<webrtc::LibvpxVp8EncoderTemplateAdapter,
-                                      webrtc::LibvpxVp9EncoderTemplateAdapter,
-                                      webrtc::OpenH264EncoderTemplateAdapter,
-                                      webrtc::LibaomAv1EncoderTemplateAdapter>
-      factory_;
-};
-
 cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
   codec.feedback_params = cricket::FeedbackParams();
   return std::move(codec);
@@ -1629,7 +1601,11 @@
         video_bitrate_allocator_factory_(
             webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
         engine_(
-            std::make_unique<FuzzyMatchedVideoEncoderFactory>(),
+            std::make_unique<webrtc::VideoEncoderFactoryTemplate<
+                webrtc::LibvpxVp8EncoderTemplateAdapter,
+                webrtc::LibvpxVp9EncoderTemplateAdapter,
+                webrtc::OpenH264EncoderTemplateAdapter,
+                webrtc::LibaomAv1EncoderTemplateAdapter>>(),
             std::make_unique<webrtc::test::FunctionVideoDecoderFactory>(
                 []() { return std::make_unique<webrtc::test::FakeDecoder>(); },
                 kSdpVideoFormats),
@@ -1763,7 +1739,11 @@
       : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
         video_bitrate_allocator_factory_(
             webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
-        engine_(std::make_unique<FuzzyMatchedVideoEncoderFactory>(),
+        engine_(std::make_unique<webrtc::VideoEncoderFactoryTemplate<
+                    webrtc::LibvpxVp8EncoderTemplateAdapter,
+                    webrtc::LibvpxVp9EncoderTemplateAdapter,
+                    webrtc::OpenH264EncoderTemplateAdapter,
+                    webrtc::LibaomAv1EncoderTemplateAdapter>>(),
                 std::make_unique<webrtc::VideoDecoderFactoryTemplate<
                     webrtc::LibvpxVp8DecoderTemplateAdapter,
                     webrtc::LibvpxVp9DecoderTemplateAdapter,