commit 42e7d9c929efeba364a455639baa5e41c52ffef3
author Ilya Nikolaevskiy <ilnik@webrtc.org> Fri Nov 02 12:14:37 2018
committer Commit Bot <commit-bot@chromium.org> Fri Nov 02 12:47:09 2018
tree 18f4a332218f627916d82f3fa2f409b177b74d4a
parent f8ba95ecee2bcee75e20bb4717639476893f3316

Enable rtc event log in *_loopback tools running with renderers

Bug: none
Change-Id: I6debe89fa972474be8862c568a23e491b678833d
Reviewed-on: https://webrtc-review.googlesource.com/c/109004
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25485}

video/video_quality_test.cc

diff --git a/video/video_quality_test.cc b/video/video_quality_test.cc
index 4800faf..08d5d1f 100644
--- a/video/video_quality_test.cc
+++ b/video/video_quality_test.cc
@@ -1243,7 +1243,28 @@
   std::unique_ptr<test::DirectTransport> recv_transport;
   std::unique_ptr<test::VideoRenderer> local_preview;
   std::vector<std::unique_ptr<test::VideoRenderer>> loopback_renderers;
-  RtcEventLogNullImpl null_event_log;
+
+  if (!params.logging.rtc_event_log_name.empty()) {
+    send_event_log_ = RtcEventLog::Create(RtcEventLog::EncodingType::Legacy);
+    recv_event_log_ = RtcEventLog::Create(RtcEventLog::EncodingType::Legacy);
+    std::unique_ptr<RtcEventLogOutputFile> send_output(
+        absl::make_unique<RtcEventLogOutputFile>(
+            params.logging.rtc_event_log_name + "_send",
+            RtcEventLog::kUnlimitedOutput));
+    std::unique_ptr<RtcEventLogOutputFile> recv_output(
+        absl::make_unique<RtcEventLogOutputFile>(
+            params.logging.rtc_event_log_name + "_recv",
+            RtcEventLog::kUnlimitedOutput));
+    bool event_log_started =
+        send_event_log_->StartLogging(std::move(send_output),
+                                      /*output_period_ms=*/5000) &&
+        recv_event_log_->StartLogging(std::move(recv_output),
+                                      /*output_period_ms=*/5000);
+    RTC_DCHECK(event_log_started);
+  } else {
+    send_event_log_ = RtcEventLog::CreateNull();
+    recv_event_log_ = RtcEventLog::CreateNull();
+  }
 
   task_queue_.SendTask([&]() {
     params_ = params;
@@ -1251,9 +1272,9 @@
 
     // TODO(ivica): Remove bitrate_config and use the default Call::Config(), to
     // match the full stack tests.
-    Call::Config send_call_config(&null_event_log);
+    Call::Config send_call_config(send_event_log_.get());
     send_call_config.bitrate_config = params_.call.call_bitrate_config;
-    Call::Config recv_call_config(&null_event_log);
+    Call::Config recv_call_config(recv_event_log_.get());
 
     if (params_.audio.enabled)
       InitializeAudioDevice(