commit 4d7e722e9d8699bfdcd01c5ab7fd531e7a43ff2d
author Diep Bui <diepbp@webrtc.org> Mon Oct 23 22:05:25 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 27 13:02:04 2023
tree 7ab8c02335fc1fa31af42f288e139a3b429b144f
parent 76c3c4553e2758139ae32216a5013d4e8e24b31e

Add 1minute as max hold duration to make sure that loss based BWE always tries to increase estimate.

Bug: webrtc:12707
Change-Id: I94689431726a37e2bfec52992046305705c6bb8a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/324741
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41025}

modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc

diff --git a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
index 1a90aa0..e26fcc6 100644
--- a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
+++ b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc
@@ -36,6 +36,7 @@
 namespace {
 
 constexpr TimeDelta kInitHoldDuration = TimeDelta::Millis(300);
+constexpr TimeDelta kMaxHoldDuration = TimeDelta::Seconds(60);
 
 bool IsValid(DataRate datarate) {
   return datarate.IsFinite();
@@ -361,7 +362,8 @@
                        << ", duration: " << hold_duration_.seconds();
       last_hold_timestamp_ =
           last_send_time_most_recent_observation_ + hold_duration_;
-      hold_duration_ = hold_duration_ * config_->hold_duration_factor;
+      hold_duration_ = std::min(kMaxHoldDuration,
+                                hold_duration_ * config_->hold_duration_factor);
     }
     last_padding_info_ = PaddingInfo();
     loss_based_result_.state = LossBasedState::kDecreasing;