| commit | 62802a1b0e668a279268b5f2d3d1ea9c10869961 | [log] [tgz] |
|---|---|---|
| author | deadbeef <deadbeef@webrtc.org> | Wed Dec 14 00:38:36 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Dec 14 00:38:46 2016 |
| tree | 09b24c4877d2125be6aa246ae0d13415ad30acf0 | |
| parent | b2362577634de26df7e824f526b40ec623b7abfa [diff] |
Fixing possible crash due to RefCountedChannel assignment operator. We relied on the default destructor of RefCountedChannel to destroy its members in reverse initialization order (deleting the DTLS wrapper before the underlying ICE channel). However, std::vector also may use the default assignment operator, which performs a member-wise copy in initialization order. Which results in deleting the ICE channel before the DTLS one. This CL fixes this by using a vector of pointers instead of structures, and uses RefCountedObject to handle ref-counting. BUG=chromium:672951 Review-Url: https://codereview.webrtc.org/2571683004 Cr-Commit-Position: refs/heads/master@{#15583}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.