commit | 34fa309129595a2b13845168ee81acac720a44a1 | [log] [tgz] |
---|---|---|
author | Alex Loiko <aleloi@webrtc.org> | Thu Nov 09 10:05:16 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 09 11:38:12 2017 |
tree | f4e268fee861313821633f9208c2131a43f58b50 | |
parent | eb0ed28b903db6a697c4a0549f69c6d84dbe21cc [diff] |
Twitter-famous NOOP bug. Between patch set 4 and patch set 5 in https://codereview.webrtc.org/2865113002/, a line consisting of a single 'std::move(task);' was added. The reason we will never know, because the author will not tell. The superfluous line would have gone unnoticed except for occasional raised eyebrows of casual code readers. The Visual Studio compiler now sees lines that have no effect. Which was announced to the world in the tweet https://twitter.com/StephanTLavavej/status/924011366943354880 achieving 27 likes and 6 retweets. Bug: webrtc:8463 Change-Id: Iac49bc4153254b6cfe99f609da28eb4f43ff765e Reviewed-on: https://webrtc-review.googlesource.com/21324 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20616}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.