commit | 6d387c0e92f033e31c8dd1efbf3f98bf159c6cf1 | [log] [tgz] |
---|---|---|
author | magjed <magjed@webrtc.org> | Wed Oct 14 11:02:01 2015 |
committer | Commit bot <commit-bot@chromium.org> | Wed Oct 14 11:02:08 2015 |
tree | b059f965cd4513dd09fe940d8c77955586d61348 | |
parent | 06b869f11a36c5abfb5e49a81ce7f88b2aa905d4 [diff] |
Android MediaCodecVideoDecoder: Limit max pending frames to number of input buffers This CL should reduce the number of timeouts for dequeueInputBuffer() which results in the log "MediaCodecVideo: dequeueInputBuffer error" followed by software fallback for VP8/VP9 and codec restart for H264. A timeout always happen for dequeueInputBuffer() when frames_received_ > frames_decoded_ + num_input_buffers. The following code tries to drain the decoder before enqueuing more input buffers: // Try to drain the decoder and wait until output is not too // much behind the input. if (frames_received_ > frames_decoded_ + max_pending_frames_) { ALOGV("Received: %d. Decoded: %d. Wait for output...", frames_received_, frames_decoded_); if (!DeliverPendingOutputs(jni, kMediaCodecTimeoutMs, true /* dropFrames */)) { ALOGE << "DeliverPendingOutputs error"; return ProcessHWErrorOnCodecThread(); } if (frames_received_ > frames_decoded_ + max_pending_frames_) { ALOGE << "Output buffer dequeue timeout"; return ProcessHWErrorOnCodecThread(); } ... } However, for H264, |max_pending_frames_| can currently be larger than the number of input buffers so that the code above is never executed. This CL limits |max_pending_frames_| to the number of input buffers. TBR=glaznev BUG=b/24867188,b/24864151 Review URL: https://codereview.webrtc.org/1394303005 Cr-Commit-Position: refs/heads/master@{#10273}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.