commit | 720954809099885f750cbb933ea376c8bf8130a7 | [log] [tgz] |
---|---|---|
author | Henrik Boström <hbos@webrtc.org> | Fri Jan 19 12:53:01 2024 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 19 14:42:10 2024 |
tree | 369346cfbfcc5a7238dc4e8858b4f69b9d91933d | |
parent | 4c335b70e84d4af4d123d9a69afa260355948b93 [diff] |
Reland "[Stats] Attribute::ToString(), to replace member ValueToString/ToJson." This is a reland of commit 54be7084e0861a0179a5fccd0b27edf7d7994bbb Previously reverted due to an importer issue (b/320646178) and later a dependency on RTCStatsMember<T>::ValueToString(). In this reland, we add Attribute::ToString() but we don't delete the RTCStatsMember<T> stringifier methods, allowing downstream to migrate before they are deleted. Original change's description: > [Stats] Attribute::ToString(), to replace member ValueToString/ToJson. > > Delete RTCStatsMember<T>::ValueToString() and ValueToJson() in favor of > Attribute::ToString(). > > The difference between "ToString" and "ToJson" is that the "ToJson" > version converts 64-bit integers and doubles to floating points with no > more than ~15 digits of precision as to not exceed JSON's precision > limitations. So only in edge cases of really large numbers or numbers > with a silly number of digits will the two methods produce different > results. Also JSON puts '\"' around map key names, e.g. "{\"foo\":123}" > as opposed to "{foo:123}". > > Going forward we see no reason to maintain two different string > converted paths that are this similar, so we only implement one > Attribute::ToString() method which does what "ToJson" did. > > In the next CL we can delete RTCStatsMember<T>. > > Bug: webrtc:15164 > Change-Id: Iaa8cf3bf14b40dc44664f75989832469603131c5 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334640 > Commit-Queue: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@google.com> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#41544} Bug: webrtc:15164 Change-Id: I281ccf5b23d8f194b5ce00186a32846c757b46fc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334860 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41575}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.