Remove PC factory options param from LocalAudioSource::Create.

It wasn't being used at all, and there's no need to tie LocalAudioSource to
PeerConnection.

BUG=None

Review-Url: https://codereview.webrtc.org/2682253002
Cr-Commit-Position: refs/heads/master@{#16550}

webrtc/pc/localaudiosource.cc

diff --git a/webrtc/pc/localaudiosource.cc b/webrtc/pc/localaudiosource.cc
index 3d79da9..5454cdf 100644
--- a/webrtc/pc/localaudiosource.cc
+++ b/webrtc/pc/localaudiosource.cc
@@ -21,31 +21,27 @@
 namespace webrtc {
 
 rtc::scoped_refptr<LocalAudioSource> LocalAudioSource::Create(
-    const PeerConnectionFactoryInterface::Options& options,
     const MediaConstraintsInterface* constraints) {
   rtc::scoped_refptr<LocalAudioSource> source(
       new rtc::RefCountedObject<LocalAudioSource>());
-  source->Initialize(options, constraints);
+  source->Initialize(constraints);
   return source;
 }
 
 rtc::scoped_refptr<LocalAudioSource> LocalAudioSource::Create(
-    const PeerConnectionFactoryInterface::Options& options,
     const cricket::AudioOptions* audio_options) {
   rtc::scoped_refptr<LocalAudioSource> source(
       new rtc::RefCountedObject<LocalAudioSource>());
-  source->Initialize(options, audio_options);
+  source->Initialize(audio_options);
   return source;
 }
 
 void LocalAudioSource::Initialize(
-    const PeerConnectionFactoryInterface::Options& options,
     const MediaConstraintsInterface* constraints) {
   CopyConstraintsIntoAudioOptions(constraints, &options_);
 }
 
 void LocalAudioSource::Initialize(
-    const PeerConnectionFactoryInterface::Options& options,
     const cricket::AudioOptions* audio_options) {
   if (!audio_options)
     return;

webrtc/pc/localaudiosource.h

diff --git a/webrtc/pc/localaudiosource.h b/webrtc/pc/localaudiosource.h
index 58e90af..ffa465d 100644
--- a/webrtc/pc/localaudiosource.h
+++ b/webrtc/pc/localaudiosource.h
@@ -13,7 +13,6 @@
 
 #include "webrtc/api/mediastreaminterface.h"
 #include "webrtc/api/notifier.h"
-#include "webrtc/api/peerconnectioninterface.h"
 #include "webrtc/media/base/mediachannel.h"
 
 // LocalAudioSource implements AudioSourceInterface.
@@ -27,11 +26,9 @@
  public:
   // Creates an instance of LocalAudioSource.
   static rtc::scoped_refptr<LocalAudioSource> Create(
-      const PeerConnectionFactoryInterface::Options& options,
       const MediaConstraintsInterface* constraints);
 
   static rtc::scoped_refptr<LocalAudioSource> Create(
-      const PeerConnectionFactoryInterface::Options& options,
       const cricket::AudioOptions* audio_options);
 
   SourceState state() const override { return kLive; }
@@ -47,10 +44,8 @@
   ~LocalAudioSource() override {}
 
  private:
-  void Initialize(const PeerConnectionFactoryInterface::Options& options,
-                  const MediaConstraintsInterface* constraints);
-  void Initialize(const PeerConnectionFactoryInterface::Options& options,
-                  const cricket::AudioOptions* audio_options);
+  void Initialize(const MediaConstraintsInterface* constraints);
+  void Initialize(const cricket::AudioOptions* audio_options);
 
   cricket::AudioOptions options_;
 };

webrtc/pc/localaudiosource_unittest.cc

diff --git a/webrtc/pc/localaudiosource_unittest.cc b/webrtc/pc/localaudiosource_unittest.cc
index 394a2ea..eb42213 100644
--- a/webrtc/pc/localaudiosource_unittest.cc
+++ b/webrtc/pc/localaudiosource_unittest.cc
@@ -21,7 +21,6 @@
 using webrtc::LocalAudioSource;
 using webrtc::MediaConstraintsInterface;
 using webrtc::MediaSourceInterface;
-using webrtc::PeerConnectionFactoryInterface;
 
 TEST(LocalAudioSourceTest, SetValidOptions) {
   webrtc::FakeConstraints constraints;
@@ -37,8 +36,7 @@
   constraints.AddOptional(MediaConstraintsInterface::kHighpassFilter, true);
 
   rtc::scoped_refptr<LocalAudioSource> source =
-      LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
-                               &constraints);
+      LocalAudioSource::Create(&constraints);
 
   EXPECT_EQ(rtc::Optional<bool>(false), source->options().echo_cancellation);
   EXPECT_EQ(rtc::Optional<bool>(true), source->options().extended_filter_aec);
@@ -52,8 +50,7 @@
 TEST(LocalAudioSourceTest, OptionNotSet) {
   webrtc::FakeConstraints constraints;
   rtc::scoped_refptr<LocalAudioSource> source =
-      LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
-                               &constraints);
+      LocalAudioSource::Create(&constraints);
   EXPECT_EQ(rtc::Optional<bool>(), source->options().highpass_filter);
 }
 
@@ -65,8 +62,7 @@
       MediaConstraintsInterface::kGoogEchoCancellation, true);
 
   rtc::scoped_refptr<LocalAudioSource> source =
-      LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
-                               &constraints);
+      LocalAudioSource::Create(&constraints);
 
   EXPECT_EQ(rtc::Optional<bool>(false), source->options().echo_cancellation);
 }
@@ -77,8 +73,7 @@
   constraints.AddOptional("invalidKey", false);
 
   rtc::scoped_refptr<LocalAudioSource> source =
-      LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
-                               &constraints);
+      LocalAudioSource::Create(&constraints);
 
   EXPECT_EQ(MediaSourceInterface::kLive, source->state());
   EXPECT_EQ(rtc::Optional<bool>(false), source->options().highpass_filter);
@@ -90,8 +85,7 @@
   constraints.AddMandatory("invalidKey", false);
 
   rtc::scoped_refptr<LocalAudioSource> source =
-      LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
-                               &constraints);
+      LocalAudioSource::Create(&constraints);
 
   EXPECT_EQ(MediaSourceInterface::kLive, source->state());
   EXPECT_EQ(rtc::Optional<bool>(false), source->options().highpass_filter);
@@ -100,14 +94,13 @@
 TEST(LocalAudioSourceTest, InitWithAudioOptions) {
   cricket::AudioOptions audio_options;
   audio_options.highpass_filter = rtc::Optional<bool>(true);
-  rtc::scoped_refptr<LocalAudioSource> source = LocalAudioSource::Create(
-      PeerConnectionFactoryInterface::Options(), &audio_options);
+  rtc::scoped_refptr<LocalAudioSource> source =
+      LocalAudioSource::Create(&audio_options);
   EXPECT_EQ(rtc::Optional<bool>(true), source->options().highpass_filter);
 }
 
 TEST(LocalAudioSourceTest, InitWithNoOptions) {
   rtc::scoped_refptr<LocalAudioSource> source =
-      LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
-                               (cricket::AudioOptions*)nullptr);
+      LocalAudioSource::Create((cricket::AudioOptions*)nullptr);
   EXPECT_EQ(rtc::Optional<bool>(), source->options().highpass_filter);
 }

webrtc/pc/peerconnectionfactory.cc

diff --git a/webrtc/pc/peerconnectionfactory.cc b/webrtc/pc/peerconnectionfactory.cc
index 1de7284..743f517 100644
--- a/webrtc/pc/peerconnectionfactory.cc
+++ b/webrtc/pc/peerconnectionfactory.cc
@@ -240,7 +240,7 @@
     const MediaConstraintsInterface* constraints) {
   RTC_DCHECK(signaling_thread_->IsCurrent());
   rtc::scoped_refptr<LocalAudioSource> source(
-      LocalAudioSource::Create(options_, constraints));
+      LocalAudioSource::Create(constraints));
   return source;
 }
 
@@ -248,7 +248,7 @@
 PeerConnectionFactory::CreateAudioSource(const cricket::AudioOptions& options) {
   RTC_DCHECK(signaling_thread_->IsCurrent());
   rtc::scoped_refptr<LocalAudioSource> source(
-      LocalAudioSource::Create(options_, &options));
+      LocalAudioSource::Create(&options));
   return source;
 }
 

webrtc/pc/rtpsenderreceiver_unittest.cc

diff --git a/webrtc/pc/rtpsenderreceiver_unittest.cc b/webrtc/pc/rtpsenderreceiver_unittest.cc
index 99380e9..4bcbb51 100644
--- a/webrtc/pc/rtpsenderreceiver_unittest.cc
+++ b/webrtc/pc/rtpsenderreceiver_unittest.cc
@@ -304,8 +304,7 @@
 TEST_F(RtpSenderReceiverTest, LocalAudioSourceOptionsApplied) {
   cricket::AudioOptions options;
   options.echo_cancellation = rtc::Optional<bool>(true);
-  auto source = LocalAudioSource::Create(
-      PeerConnectionFactoryInterface::Options(), &options);
+  auto source = LocalAudioSource::Create(&options);
   CreateAudioRtpSender(source.get());
 
   EXPECT_EQ(rtc::Optional<bool>(true),