Enabling clang::find_bad_constructs for libjingle_peerconnection_api.
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.
Bug: webrtc:9251, webrtc:163
Change-Id: I5475e574353c772910181495fdb3400b5f0e7399
Reviewed-on: https://webrtc-review.googlesource.com/87240
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24040}diff --git a/api/datachannelinterface.h b/api/datachannelinterface.h
index 5cbe717..a0d2b3b 100644
--- a/api/datachannelinterface.h
+++ b/api/datachannelinterface.h
@@ -88,7 +88,7 @@
virtual void OnBufferedAmountChange(uint64_t previous_amount) {}
protected:
- virtual ~DataChannelObserver() {}
+ virtual ~DataChannelObserver() = default;
};
class DataChannelInterface : public rtc::RefCountInterface {
@@ -134,11 +134,11 @@
// TODO(deadbeef): Remove these dummy implementations when all classes have
// implemented these APIs. They should all just return the values the
// DataChannel was created with.
- virtual bool ordered() const { return false; }
- virtual uint16_t maxRetransmitTime() const { return 0; }
- virtual uint16_t maxRetransmits() const { return 0; }
- virtual std::string protocol() const { return std::string(); }
- virtual bool negotiated() const { return false; }
+ virtual bool ordered() const;
+ virtual uint16_t maxRetransmitTime() const;
+ virtual uint16_t maxRetransmits() const;
+ virtual std::string protocol() const;
+ virtual bool negotiated() const;
// Returns the ID from the DataChannelInit, if it was negotiated out-of-band.
// If negotiated in-band, this ID will be populated once the DTLS role is
@@ -170,7 +170,7 @@
virtual bool Send(const DataBuffer& buffer) = 0;
protected:
- virtual ~DataChannelInterface() {}
+ ~DataChannelInterface() override = default;
};
} // namespace webrtc
