commit 7fa9057a0558e315f822c505b1f4516952c9f6cc
author Ali Tofigh <alito@webrtc.org> Thu Mar 17 14:47:49 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Mar 17 15:39:26 2022
tree 5eabbb2add5558f6b206502b9f204fb90ca7cb7a
parent 1a08096998a38a40f76ed7b014805c3d7edfac4d

Adopt absl::string_view in function parameters under rtc_base/

This is part of a large-scale effort to increase adoption of
absl::string_view across the WebRTC code base.

This CL converts the majority of "const std::string&"s in function
parameters under rtc_base/ to absl::string_view.

Bug: webrtc:13579
Change-Id: I2b1e3776aa42326aa405f76bb324a2d233b21dca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254081
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org>
Reviewed-by: Anders Lilienthal <andersc@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36239}

rtc_base/boringssl_certificate.cc

diff --git a/rtc_base/boringssl_certificate.cc b/rtc_base/boringssl_certificate.cc
index 99b2ab3..a866224 100644
--- a/rtc_base/boringssl_certificate.cc
+++ b/rtc_base/boringssl_certificate.cc
@@ -10,6 +10,8 @@
 
 #include "rtc_base/boringssl_certificate.h"
 
+#include "absl/strings/string_view.h"
+
 #if defined(WEBRTC_WIN)
 // Must be included first before openssl headers.
 #include "rtc_base/win32.h"  // NOLINT
@@ -116,7 +118,7 @@
 }
 
 // Adds an X.509 Common Name to `cbb`.
-bool AddCommonName(CBB* cbb, const std::string& common_name) {
+bool AddCommonName(CBB* cbb, absl::string_view common_name) {
   // See RFC 4519.
   static const uint8_t kCommonName[] = {0x55, 0x04, 0x03};
 
@@ -138,7 +140,7 @@
       !CBB_add_bytes(&type, kCommonName, sizeof(kCommonName)) ||
       !CBB_add_asn1(&attr, &value, CBS_ASN1_UTF8STRING) ||
       !CBB_add_bytes(&value,
-                     reinterpret_cast<const uint8_t*>(common_name.c_str()),
+                     reinterpret_cast<const uint8_t*>(common_name.data()),
                      common_name.size()) ||
       !CBB_flush(cbb)) {
     return false;
@@ -275,7 +277,7 @@
 }
 
 std::unique_ptr<BoringSSLCertificate> BoringSSLCertificate::FromPEMString(
-    const std::string& pem_string) {
+    absl::string_view pem_string) {
   std::string der;
   if (!SSLIdentity::PemToDer(kPemTypeCertificate, pem_string, &der)) {
     return nullptr;
@@ -340,7 +342,7 @@
   return false;
 }
 
-bool BoringSSLCertificate::ComputeDigest(const std::string& algorithm,
+bool BoringSSLCertificate::ComputeDigest(absl::string_view algorithm,
                                          unsigned char* digest,
                                          size_t size,
                                          size_t* length) const {
@@ -348,7 +350,7 @@
 }
 
 bool BoringSSLCertificate::ComputeDigest(const CRYPTO_BUFFER* cert_buffer,
-                                         const std::string& algorithm,
+                                         absl::string_view algorithm,
                                          unsigned char* digest,
                                          size_t size,
                                          size_t* length) {