commit 86d053c2db6ed25e4854c307d563999298dda2e5
author Mirko Bonadei <mbonadei@webrtc.org> Thu Oct 17 19:32:04 2019
committer Commit Bot <commit-bot@chromium.org> Thu Oct 17 21:17:18 2019
tree 170909a876f1443e0cec6defac0ac5ea5f4cbc56
parent e8b962bd3c9775b2859f908004263dbc8840629a

Use source_sets in component builds and static_library in release builds.

Static libraries don't guarantee that an exported symbol gets linked
into a shared library (and in order to support Chromium's component
build mode, WebRTC needs to be linked as a shared library).

Source sets always pass all the object files to the linker.

On the flip side, source_sets link more object files in release builds
and to avoid this, this CL introduces a the GN template "rtc_library" that
expands to static_library during release builds and to source_set during
component builds.

See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set

Bug: webrtc:9419
Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#29525}

presubmit_test.py

diff --git a/presubmit_test.py b/presubmit_test.py
index d6e5129..287071c 100755
--- a/presubmit_test.py
+++ b/presubmit_test.py
@@ -160,7 +160,7 @@
 
   def testNoErrorIfSourcesAreInExclusiveIfBranches(self):
     self._GenerateBuildFile(textwrap.dedent("""
-      rtc_source_set("bar_foo") {
+      rtc_library("bar_foo") {
         if (is_win) {
           sources = [
             "bar.cc",
@@ -172,7 +172,7 @@
           ],
         }
       }
-      rtc_source_set("foo_bar") {
+      rtc_library("foo_bar") {
         if (is_win) {
           sources = [
             "foo.cc",
@@ -193,7 +193,7 @@
 
   def testErrorIfSourcesAreNotInExclusiveIfBranches(self):
     self._GenerateBuildFile(textwrap.dedent("""
-      rtc_source_set("bar_foo") {
+      rtc_library("bar_foo") {
         if (is_win) {
           sources = [
             "bar.cc",
@@ -205,7 +205,7 @@
           ],
         }
       }
-      rtc_source_set("foo_bar") {
+      rtc_library("foo_bar") {
         if (is_win) {
           sources = [
             "foo.cc",
@@ -246,7 +246,7 @@
           "%s",
         ],
       }
-      rtc_source_set("foo_bar") {
+      rtc_library("foo_bar") {
         sources = [
           "%s",
           "%s",