| commit | 9674d7cb89228509203b846f27a74af84762f682 | [log] [tgz] |
|---|---|---|
| author | jbauch <jbauch@webrtc.org> | Fri Feb 19 15:16:16 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Feb 19 15:16:19 2016 |
| tree | 339f9601c79699cbe0d089eedff01c691611cd51 | |
| parent | fc968a283c91cd4395b0ee8f232d29d566cc1316 [diff] |
Revert of Prevent data race in MessageQueue. (patchset #3 id:40001 of https://codereview.webrtc.org/1675923002/ ) Reason for revert: Broke chromium.webrtc.fyi bots: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/9891 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20GN/builds/11416 Fails with ----- Undefined symbols for architecture x86_64: "rtc::SharedExclusiveLock::LockShared()", referenced from: rtc::MessageQueue::DoDestroy() in librtc_base.a(messagequeue.o) rtc::MessageQueue::socketserver() in librtc_base.a(messagequeue.o) rtc::MessageQueue::WakeUpSocketServer() in librtc_base.a(messagequeue.o) rtc::MessageQueue::Quit() in librtc_base.a(messagequeue.o) rtc::MessageQueue::Get(rtc::Message*, int, bool) in librtc_base.a(messagequeue.o) rtc::MessageQueue::Post(rtc::MessageHandler*, unsigned int, rtc::MessageData*, bool) in librtc_base.a(messagequeue.o) rtc::MessageQueue::DoDelayPost(int, unsigned int, rtc::MessageHandler*, unsigned int, rtc::MessageData*) in librtc_base.a(messagequeue.o) ... "rtc::SharedExclusiveLock::UnlockShared()", referenced from: rtc::MessageQueue::DoDestroy() in librtc_base.a(messagequeue.o) rtc::MessageQueue::socketserver() in librtc_base.a(messagequeue.o) rtc::MessageQueue::WakeUpSocketServer() in librtc_base.a(messagequeue.o) rtc::MessageQueue::Quit() in librtc_base.a(messagequeue.o) rtc::MessageQueue::Get(rtc::Message*, int, bool) in librtc_base.a(messagequeue.o) rtc::MessageQueue::Post(rtc::MessageHandler*, unsigned int, rtc::MessageData*, bool) in librtc_base.a(messagequeue.o) rtc::MessageQueue::DoDelayPost(int, unsigned int, rtc::MessageHandler*, unsigned int, rtc::MessageData*) in librtc_base.a(messagequeue.o) ... "rtc::SharedExclusiveLock::SharedExclusiveLock()", referenced from: rtc::MessageQueue::MessageQueue(rtc::SocketServer*, bool) in librtc_base.a(messagequeue.o) ld: symbol(s) not found for architecture x86_64 ----- Looks like these are compiling without "webrtc/base/sharedexclusivelock.cc". Original issue's description: > Prevent data race in MessageQueue. > > The CL prevents a data race in MessageQueue where the variable "ss_" is > modified without a lock while sometimes read inside a lock. > > Also thread annotations have been added to the MessageQueue class. > > BUG=webrtc:5496 > > Committed: https://crrev.com/df88460372e7ce78c871a87774d7e6d82aac6ee3 > Cr-Commit-Position: refs/heads/master@{#11683} TBR=ivoc@webrtc.org,pthatcher@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5496 Review URL: https://codereview.webrtc.org/1714463003 Cr-Commit-Position: refs/heads/master@{#11686}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.