commit 969486666bcec6690066a3e883b97081934396a7
author Tommi <tommi@webrtc.org> Wed May 21 13:55:38 2025
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 21 15:06:54 2025
tree d92402942fa4da07a310631bee9051e3bcbb1cfd
parent 7d7dcb9650d67a6085a4f4a038edd45c2f4b65b5

Add stricter checks for valid NetEq configs.

This is a step towards moving config checks away from the audio path and
closer to the initial config/construction path. Construction of decoder
instances is similarly more rigorously checked.

* NetEq can no longer accept 1000 audio channels as a valid config.
  (see NoCrashWith1000Channels test)
* Improve checking for valid configurations when constructing
  encoders/decoders. The checks are now more aligned with the
  limits of the internal classes such as NetEqImpl and AudioFrame
  rather than e.g. using a value of 255 for channel count.
* Consolidate constant definitions of "max number of audio channels".
  This CL adds one constant with a default value of 24.
* Updating similar constants for encoders and decoders to refer to
  that value.
* Updating AudioFrame to use the new value for sanity checking.
  Since AudioFrame has public member variables, those checks were
  being, and continue to be, bypassed unfortunately, but this is
  some progress.

Bug: chromium:335805780, chromium:40057791
Change-Id: Ib015d1223f2c3fc00c66a831b1fa851fa50a940d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/392380
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#44718}