commit | ac025898e1e76a688dea5ea9e3681dd8dc2ce856 | [log] [tgz] |
---|---|---|
author | Karl Wiberg <kwiberg@webrtc.org> | Tue Mar 26 12:08:37 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 26 12:51:34 2019 |
tree | d5e2fca49feadd997d78cc9d8da270be8693623e | |
parent | 89cc7d43e66e2229d3261fe46996674730e9df91 [diff] |
Fix misunderstanding: OnTransportChanged is called on network thread Earlier CLs assumed that the object pointed to by call_ had to be accessed on the worker thread. While this is generally the case, Call::MediaTransportChange is explicitly thread safe, so PeerConnection::OnTransportChanged doesn't have to run on the worker thread for that reason. Which is fortunate, because it actually runs on the network thread. The RTC_RUN_ON(worker_thread()) annotation on the method declaration was ineffective because this method is being called via a base class pointer; replacing it with a call to RTC_DCHECK_RUN_ON(worker_thread()) in the function body immediately triggered assertions in the unit tests. Bug: webrtc:9987 Change-Id: I08cf558a74f4ca2b2eff8ef4810ebbd1287a9726 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129442 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27287}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.